Add fixtures cache and Telescope picker for ambiguous fixtures#10
Open
Nosterx wants to merge 5 commits intoAckslD:mainfrom
Open
Add fixtures cache and Telescope picker for ambiguous fixtures#10Nosterx wants to merge 5 commits intoAckslD:mainfrom
Nosterx wants to merge 5 commits intoAckslD:mainfrom
Conversation
…ommand that warms up the cache upon entering a test file.
…n choices for a given fixture name
This was referenced Feb 15, 2025
AckslD
reviewed
Mar 12, 2025
lua/pytrize/init.lua
Outdated
| if not settings.settings.no_commands then | ||
| setup_commands() | ||
| end | ||
| create_autocmd() |
Owner
There was a problem hiding this comment.
Maybe this could at least be opt-out? Same as the commands above
Author
There was a problem hiding this comment.
Thanks for the suggestion! I've added a configuration option to enable/disable the auto-commands feature. If auto-commands are disabled, the fixture cache will still be populated when the to_declaration method is called. Let me know if you have any further feedback! 😊
Owner
|
@Nosterx! This looks great, nice work! Also thanks for submitting a clean PR :) I just have one question above, otherwise happy to merge. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces the following changes:
Fixture Caching:
pytest --fixture -v command, which can take several seconds (up to six seconds in my experience) in large codebases.Handling Ambiguous Fixtures: