Rock - Mai #71
Open
Rock - Mai #71
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spitsfire
reviewed
Jun 12, 2021
spitsfire
left a comment
spitsfire
left a comment
There was a problem hiding this comment.
Mai, there's a lot of great things going on here! Everything is nicely separated, even helper functions. The only thing I saw that you could check out are the CLI results when a user creates/updates a customer with blank data.
It returns a success and creates a blank customer or updates a customer with blank data. Video and rentals, however, caught this! This is not really the CLI's issue, but that's really the only thing I saw that could be refactored!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.