Add tokio, futures, chrono, hex dependencies#12
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 2ae0ee1a11
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| use crate::{Error, Result}; | ||
|
|
||
| /// Fingerprint size in bytes (10,000 bits = 1,250 bytes) | ||
| pub const FINGERPRINT_BYTES: usize = 1250; |
There was a problem hiding this comment.
The Lance schema hardcodes FINGERPRINT_BYTES as 1250, but Fingerprint::to_bytes/from_bytes in src/core/fingerprint.rs expect FINGERPRINT_U64 * 8 (1256) bytes. When NodeRecord::with_fingerprint calls Fingerprint::to_bytes, FixedSizeBinaryBuilder will reject the 1256‑byte buffer or later reads will fail in Fingerprint::from_bytes. This breaks storing or querying fingerprints as soon as a non‑empty fingerprint is used. Align the schema byte width with the core fingerprint size (or change serialization) so inserts and reads are consistent.
Useful? React with 👍 / 👎.
| if c == '-' { | ||
| if i + 1 < chars.len() && chars[i + 1] == '>' { | ||
| tokens.push(Token::Arrow); | ||
| i += 2; | ||
| continue; | ||
| } else { | ||
| tokens.push(Token::Dash); |
There was a problem hiding this comment.
The tokenizer consumes '-' as Dash/Arrow before the numeric‑literal branch runs. As a result, -1 is tokenized as Dash + IntLit(1) and the parser has no unary minus handling, so Cypher queries with negative literals (e.g., WHERE a.score < -1) will fail to parse. Consider handling the '-' case in the numeric branch before treating it as a pattern dash.
Useful? React with 👍 / 👎.
1 participant
No description provided.