deprecate(server): move JSON hydrate endpoints to .deprecated#129
Open
AdaWorldAPI wants to merge 2 commits intomainfrom
Open
deprecate(server): move JSON hydrate endpoints to .deprecated#129AdaWorldAPI wants to merge 2 commits intomainfrom
AdaWorldAPI wants to merge 2 commits intomainfrom
Conversation
PR #127 + #128 added POST /api/v1/qualia/hydrate and write-back. These are rolled back because: 1. Internal operations must never serialize to JSON 2. text_to_dn() is hash soup — DN must carry semantic meaning 3. Pipeline was hollow (hardcoded defaults, match i%8 ghost types) 4. Wrong paradigm: HTTP between crates that share one binary The code is preserved in .deprecated/pr127_128_json_hydrate/ for reference. The rewrite will use &BindSpace borrows directly. Removed from server.rs: - POST /api/v1/qualia/hydrate handler (~240 lines) - POST /api/v1/qualia/write-back handler (~100 lines) - text_to_container(), text_to_dn() helpers - DbState.qualia_graph, DbState.self_dims fields - Hydrate-only imports (ContainerGraph, AgentState, etc.) Total: -418 lines from server.rs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Deprecation: PR #127 + #128 JSON Hydrate Endpoints
What's moved to
.deprecated/pr127_128_json_hydrate/server_hydrate_block.rs— extracted ~400 lines fromsrc/bin/server.rsREADME.md— rationale and salvage notesWhat's removed from
server.rs(-418 lines)POST /api/v1/qualia/hydratehandlerPOST /api/v1/qualia/write-backhandlertext_to_container(),text_to_dn()helpersDbState.qualia_graph,DbState.self_dimsfieldsWhy
&self/&mut selfborrowsmatch i % 8ghost typesWhat stays
felt_parse.rs,agent_state.rs) — real substrate work ✅/api/v1/graph/*) — unchanged ✅Policy: RISC not CISC
Neo4j-rs becomes a Cypher parser emitting direct BindSpace operations.
No intermediate executor. No DTO translation.
&Containerall the way down.