Add src/cognitive/grammar_engine.rs (audit recovery from session)#16
Add src/cognitive/grammar_engine.rs (audit recovery from session)#16AdaWorldAPI wants to merge 2 commits intomainfrom
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: fc66829d01
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| let consciousness_resonance = input.similarity(&state.consciousness.vsa_core); | ||
|
|
||
| // mRNA field resonance | ||
| let field_resonances = self.mrna.pollinate(input); |
There was a problem hiding this comment.
In cognitive_cycle, the input is already added to the mRNA field via pollinate before calling query, but query itself calls self.mrna.pollinate(input) again. This inserts the same concept twice, inflating concept counts/history and skewing the returned resonance and butterfly statistics compared to the single-pass results you return from the cycle. If the query is meant to be read-only, consider using a snapshot/lookup API or reusing the resonances from step 1 instead of re‑pollinating.
Useful? React with 👍 / 👎.
1 participant
No description provided.