Commit 1bb4561
committed
docs(pr-x12): address CR + codex feedback on PR #198
Two open review threads on the second commit:
1. R-15 falsifiability row (substrate-canon-resolutions.md §9, line 1250)
Both codex-connector and CodeRabbit flagged that the matrix row
required "path reconstruction under Pillar 11" but R-15 itself marks
invert() as unimplemented! (path-from-signature is many-to-one up
to tree-like equivalence — Hambly-Lyons). The gate was operationally
untestable.
Reframed per CR's suggestion: "signature-space discrimination under
Pillar 11 (forward-only — path inversion is N/A per R-15)" with the
same probe criteria Pillar 11 uses (forward < 1e-9, converse > 0.05,
discrimination ratio >= 1e6, or agreed DEPTH-specific floor).
2. build.rs host-vs-target semantics (woa-multiarch §3.3, line 133)
CR pointed out that under cross-compilation Cargo runs build.rs on
the HOST, so any "feature-detection probe" in build.rs reflects the
build machine, not the target. My original wording ("target_arch /
target_feature cfgs + a feature-detection probe") implied host CPU
probing — wrong.
Rewrote the pseudocode + surrounding text to explicitly use
CARGO_CFG_TARGET_ARCH, CARGO_CFG_TARGET_FEATURE, target triple, and
pre-recorded calibration artifacts. Added an explicit "do NOT probe
the host CPU inside build.rs" warning citing Cargo's docs. The
in-crate cfg!() fallback shape is still correct (cfg! in normal
code reflects target cfgs); only build.rs's cfg!/#[cfg] reflects
the host.
https://claude.ai/code/session_01HbqooFZHAjaUtFEzhA1R2u1 parent 6f96a14 commit 1bb4561
2 files changed
Lines changed: 13 additions & 12 deletions
File tree
- .claude/knowledge
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1247 | 1247 | | |
1248 | 1248 | | |
1249 | 1249 | | |
1250 | | - | |
| 1250 | + | |
1251 | 1251 | | |
1252 | 1252 | | |
1253 | 1253 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
130 | 130 | | |
131 | 131 | | |
132 | 132 | | |
133 | | - | |
| 133 | + | |
134 | 134 | | |
135 | 135 | | |
136 | 136 | | |
| |||
139 | 139 | | |
140 | 140 | | |
141 | 141 | | |
142 | | - | |
143 | | - | |
144 | | - | |
145 | | - | |
146 | | - | |
147 | | - | |
148 | | - | |
| 142 | + | |
| 143 | + | |
| 144 | + | |
| 145 | + | |
| 146 | + | |
| 147 | + | |
| 148 | + | |
| 149 | + | |
149 | 150 | | |
150 | | - | |
151 | | - | |
| 151 | + | |
| 152 | + | |
152 | 153 | | |
153 | 154 | | |
154 | 155 | | |
| |||
163 | 164 | | |
164 | 165 | | |
165 | 166 | | |
166 | | - | |
| 167 | + | |
167 | 168 | | |
168 | 169 | | |
169 | 170 | | |
| |||
0 commit comments