Suggested fix for issue #224, FlxTilemap.ray() Result value always null#225
Open
cr0ybot wants to merge 1 commit intoAdamAtomic:masterfrom
Open
Suggested fix for issue #224, FlxTilemap.ray() Result value always null#225cr0ybot wants to merge 1 commit intoAdamAtomic:masterfrom
cr0ybot wants to merge 1 commit intoAdamAtomic:masterfrom
Conversation
…oint if the ray hits anything, and returns null otherwise. Default ray() function relies on passing a variable as reference to receive the hit result, which does not seem to work. See http://stackoverflow.com/questions/3708371/actionscript-pass-by-reference
|
This is unnecessary, see: #224 (comment) A better fix would be to change: if(Result == null)
Result = new FlxPoint();
Result.x = rx;
Result.y = ry;
return false;to if(Result != null)
{
Result.x = rx;
Result.y = ry;
}
return false;This makes the code clearer and removes an unnecessary new FlxPoint() creation. |
Gama11
added a commit
to HaxeFlixel/flixel
that referenced
this pull request
Mar 31, 2014
ray() has exactly the same functionality, it just needed a small fix (see AdamAtomic/flixel#225)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added rayHit() function to FlxTilemap that explicitly returns an FlxPoint if the ray hits anything, and returns null otherwise. Default ray() function relies on passing a variable as reference to receive the hit result, which does not seem to work. See http://stackoverflow.com/questions/3708371/actionscript-pass-by-reference