Skip to content

Conversation

@ym3141
Copy link
Contributor

@ym3141 ym3141 commented May 21, 2025

Should resolves #32

@Adibvafa
Copy link
Owner

Thank you for this PR! I will run the tests now.

@Adibvafa Adibvafa self-requested a review May 21, 2025 20:32
@ym3141 ym3141 changed the title relax the requirement of onnxruntime to <=1.16.3 relax the requirement of onnxruntime to >=1.16.3 May 21, 2025
@codecov
Copy link

codecov bot commented May 21, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.53%. Comparing base (2842ef0) to head (44e65b7).
Report is 17 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #33      +/-   ##
==========================================
- Coverage   81.89%   81.53%   -0.36%     
==========================================
  Files           8        8              
  Lines         972      975       +3     
==========================================
- Hits          796      795       -1     
- Misses        176      180       +4     
Flag Coverage Δ
unittests 81.53% <ø> (-0.36%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Adibvafa Adibvafa merged commit 998be51 into Adibvafa:main May 21, 2025
3 of 4 checks passed
Copy link
Owner

@Adibvafa Adibvafa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ym3141
Copy link
Contributor Author

ym3141 commented May 21, 2025

Hi... Just looking at the test, I don't think the test is proper, though I don't object the merge either. If you go to the "installing dependency" part of the test, it still installed onnxruntime 1.22, as the requirement only says >=1.16. So nothing new is really tested. I can try to run the test on my side with 1.16 again just out of caution, but I don't expect major issues though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

The package seems to work with onnxruntime==1.6.3, suggesting relaxing the requirement.

2 participants