Skip to content

Remove pre-commit from nox for lack of a config file #295

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
kurtmckee wants to merge 1 commit into from
Closed

Remove pre-commit from nox for lack of a config file #295

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 0 additions & 5 deletions .github/copilot-instructions.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -123,12 +123,7 @@ python -m GSASII
### Linting and Code Quality
```bash
# Using nox (recommended)
python -m nox -s lint # Pre-commit hooks and formatting
python -m nox -s pylint # Static code analysis

# Manual linting
python -m pip install pre-commit
pre-commit run --all-files
```

### Documentation
Expand Down
16 changes: 2 additions & 14 deletions noxfile.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,27 +8,15 @@

DIR = Path(__file__).parent.resolve()

nox.options.sessions = ["lint", "pylint", "tests"]


@nox.session
def lint(session: nox.Session) -> None:
"""
Run the linter.
"""
session.install("pre-commit")
session.run(
"pre-commit", "run", "--all-files", "--show-diff-on-failure", *session.posargs
)
nox.options.sessions = ["pylint", "tests"]


@nox.session
def pylint(session: nox.Session) -> None:
"""
Run PyLint.
"""
# This needs to be installed into the package environment, and is slower
# than a pre-commit check
# This needs to be installed into the package environment
session.install(".", "pylint")
session.run("pylint", "gsas_ii", *session.posargs)

Expand Down