Skip to content

FIX - update Github actions to have format action in place for generated code#462

Merged
thomasc-adyen merged 1 commit intomainfrom
feature/enable-format-action-for-generated-code
Mar 23, 2026
Merged

FIX - update Github actions to have format action in place for generated code#462
thomasc-adyen merged 1 commit intomainfrom
feature/enable-format-action-for-generated-code

Conversation

@thomasc-adyen
Copy link
Contributor

Also updated the install steps to source the Ruff version from pyproject.toml

@thomasc-adyen thomasc-adyen requested review from a team as code owners March 23, 2026 09:10
@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request introduces a new GitHub Action to standardize and automate Python code formatting and linting across the repository. By integrating ruff directly into the CI/CD pipeline, it ensures consistent code style and quality, reducing manual effort and potential errors.

Highlights

  • New GitHub Action for Python Formatting: Introduced a new composite GitHub Action (.github/actions/format/action.yml) to automate Python code formatting and linting using ruff.
  • Automated Ruff Execution: The new action is configured to set up Python 3.8, install ruff from development dependencies, and then execute ruff format and ruff check --fix on the Adyen directory.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Ignored Files
  • Ignored by pattern: .github/workflows/** (1)
    • .github/workflows/lint.yml
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@sonarqubecloud
Copy link

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces a new composite GitHub Action to automatically format Python code using ruff. The action sets up Python, installs dependencies including ruff from pyproject.toml, and then runs ruff format and ruff check --fix. My review includes a suggestion to make the action more robust and reusable by not hardcoding the directory path for ruff commands, allowing it to format the entire project based on its configuration.

@thomasc-adyen thomasc-adyen added this pull request to the merge queue Mar 23, 2026
Merged via the queue into main with commit 91b0ea0 Mar 23, 2026
14 checks passed
@thomasc-adyen thomasc-adyen deleted the feature/enable-format-action-for-generated-code branch March 23, 2026 09:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants