Skip to content

[balanceplatform] Code generation: update services and models#464

Merged
thomasc-adyen merged 1 commit intomainfrom
sdk-automation/balanceplatform
Mar 23, 2026
Merged

[balanceplatform] Code generation: update services and models#464
thomasc-adyen merged 1 commit intomainfrom
sdk-automation/balanceplatform

Conversation

@AdyenAutomationBot
Copy link
Collaborator

This PR contains the automated changes for the balanceplatform service.

The commit history of this PR reflects the adyen-openapi commits that have been applied.

@AdyenAutomationBot AdyenAutomationBot requested review from a team as code owners March 23, 2026 13:19
@sonarqubecloud
Copy link

@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request introduces new functionalities to the Adyen Balance Platform API, specifically focusing on direct debit mandates and tax form summaries. It enhances the API's capabilities by providing endpoints to manage direct debit mandates and retrieve summarized tax form information for account holders.

Highlights

  • New API Addition: Introduced the DirectDebitMandatesApi to manage direct debit mandates within the balance platform.
  • Tax Form Summary Endpoint: Added a new endpoint to retrieve summaries of tax forms for account holders.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces automated changes for the balanceplatform service, adding the DirectDebitMandatesApi and a new method to AccountHoldersApi. The changes are mostly correct and follow the existing project structure. I've added one comment regarding the use of id as a parameter name, which shadows a Python built-in, suggesting a more descriptive name to improve code clarity.

Comment on lines +66 to +74
def get_tax_form_summary(self, id, idempotency_key=None, **kwargs):
"""
Get summary of tax forms for an account holder
"""
endpoint = self.baseUrl + f"/accountHolders/{id}/taxFormSummary"
method = "GET"
return self.client.call_adyen_api(
None, self.service, method, endpoint, idempotency_key, **kwargs
)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The parameter id shadows the built-in Python function id(). To avoid potential bugs and improve code clarity, it's recommended by PEP 8 to use a different name, such as account_holder_id. Since this is auto-generated code, this is a good opportunity to fix it in the generator to apply this good practice consistently across the codebase.

Suggested change
def get_tax_form_summary(self, id, idempotency_key=None, **kwargs):
"""
Get summary of tax forms for an account holder
"""
endpoint = self.baseUrl + f"/accountHolders/{id}/taxFormSummary"
method = "GET"
return self.client.call_adyen_api(
None, self.service, method, endpoint, idempotency_key, **kwargs
)
def get_tax_form_summary(self, account_holder_id, idempotency_key=None, **kwargs):
"""
Get summary of tax forms for an account holder
"""
endpoint = self.baseUrl + f"/accountHolders/{account_holder_id}/taxFormSummary"
method = "GET"
return self.client.call_adyen_api(
None, self.service, method, endpoint, idempotency_key, **kwargs
)
References
  1. PEP 8, the style guide for Python code, recommends against using names that shadow built-ins. The name 'id' shadows the built-in id() function, which can lead to confusion and subtle bugs. (link)

@thomasc-adyen thomasc-adyen added this pull request to the merge queue Mar 23, 2026
Merged via the queue into main with commit a04a3cc Mar 23, 2026
26 checks passed
@thomasc-adyen thomasc-adyen deleted the sdk-automation/balanceplatform branch March 23, 2026 16:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants