IEX-2493 add pydantic v2 as core dependency#467
Merged
thomasc-adyen merged 2 commits intomainfrom Mar 27, 2026
Merged
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request adds pydantic>=2.0 as a core dependency by updating pyproject.toml, setup.py, and tox.ini. The review feedback identifies that the changes to setup.py and tox.ini are redundant, as pyproject.toml serves as the source of truth for package metadata and tox automatically installs core dependencies during the test environment setup.
thomasc-adyen
force-pushed
the
feature/IEX-2493-add-pydantic-v2-as-core-dependency
branch
from
57305c8 to
671e5b7
Compare
|
galesky-a
approved these changes
Mar 27, 2026
thomasc-adyen
deleted the
feature/IEX-2493-add-pydantic-v2-as-core-dependency
branch
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We want to start moving towards using Pydantic to align with industry standards for Python SDKs, provide type-safety at runtime, and a host of other benefits.