Conversation
elpiel
left a comment
elpiel
left a comment
There was a problem hiding this comment.
- run
cargo fmt&cargo clippy(we don't have a CI for these checks yet but you should run them on the code locally.)
As an additional note, I saw that there is a FenceType which can be used on a Polygon, but the Polygon itself uses i32 inside. We should improve this API in the future.
|
|
||
| let upload_geofence_request = mav_sdk::grpc::geofence::UploadGeofenceRequest { polygons: vec![ | ||
| mav_sdk::grpc::geofence::Polygon { | ||
| points:vec![mav_sdk::grpc::geofence::Point{ latitude_deg: 0.0, longitude_deg: 0.0 },mav_sdk::grpc::geofence::Point{ latitude_deg: 0.0, longitude_deg: 0.0 },mav_sdk::grpc::geofence::Point{ latitude_deg: 0.0, longitude_deg: 0.0 },mav_sdk::grpc::geofence::Point{ latitude_deg: 0.0, longitude_deg: 0.0 },], fence_type: 0, }, |
There was a problem hiding this comment.
Ok, that's a great start. could we just add actual coordinates here?
-
Let's use the actual GPS coordinates of the drone (at the moment) and update the Polygon accordingly.
E.g.current coordinates +/- a value in degreesin all directions to get a rectangle with a given size. Keep in mind that we work with degrees here so that we can define the distance in degrees, instead of size (i.e. ~0.125 degrees instead of ~14 km). We do need to choose a valid value as "Each degree of latitude is approximately 111 kilometres apart" (https://www.thoughtco.com/degree-of-latitude-and-longitude-distance-4070616). -
Import
Point,UploadGeofenceRequest,ClearGeofenceRequest
2 participants
No description provided.