Skip to content

Fix CASE statement WHEN spacing #231

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
git-hulk merged 1 commit into from
Jan 23, 2026
Merged

Fix CASE statement WHEN spacing #231

git-hulk merged 1 commit into from
Jan 23, 2026

Conversation

@rhino1998
Copy link
Contributor

@rhino1998 rhino1998 commented Jan 22, 2026

This fixes the CaseExpr String() method to output

CASE WHEN cond1 THEN val1 WHEN cond2 THEN val2`

instead of

CASE WHEN cond1 THEN val1WHEN cond2 THEN val2`

(notice the missing space between val1 and WHEN)

@coveralls
Copy link

coveralls commented Jan 22, 2026

Pull Request Test Coverage Report for Build 21262661987

Details

  • 4 of 4 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.006%) to 51.357%
Totals Coverage Status
Change from base Build 21249588693: 0.006%
Covered Lines: 8024
Relevant Lines: 15624
💛 - Coveralls

@git-hulk git-hulk merged commit 2154d0b into AfterShip:master Jan 23, 2026
1 check passed
@git-hulk
Copy link
Member

git-hulk commented Jan 23, 2026

@rhino1998 Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@git-hulk git-hulk git-hulk approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@rhino1998 @coveralls @git-hulk