Skip to content

Add support for nested named/unnamed tuple types #233

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
rhino1998 wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add support for nested named/unnamed tuple types #233

rhino1998 wants to merge 1 commit into from
+608 −2

Conversation

@rhino1998
Copy link
Contributor

@rhino1998 rhino1998 commented Jan 26, 2026 •
edited
Loading

This adds support for nested named and unnamed types with parameters like

    Tuple()
    Tuple(String, Int64)
    Tuple(String, Tuple(String, String))
    Tuple(a String, cd Tuple(c String, d String))

@coveralls
Copy link

coveralls commented Jan 26, 2026

Pull Request Test Coverage Report for Build 21345979922

Details

  • 68 of 93 (73.12%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.1%) to 51.493%
Changes Missing Coverage Covered Lines Changed/Added Lines %
parser/parser_column.go 68 93 73.12%
Totals Coverage Status
Change from base Build 21280479720: 0.1%
Covered Lines: 8103
Relevant Lines: 15736
💛 - Coveralls

@git-hulk git-hulk self-requested a review January 26, 2026 10:18
git-hulk
git-hulk reviewed Jan 26, 2026
View reviewed changes
Copy link
Member

@git-hulk git-hulk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rhino1998 Thanks for your contribution. Left two naming suggestions.

parser/parser_column.go
}
}

func (p *Parser) parseNestedTypeFieldsWithNames(firstIdent *Ident) ([]Expr, error) {
Copy link
Member

@git-hulk git-hulk Jan 26, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

firstIdent => columnName

parser/parser_column.go
return columns, nil
}

func (p *Parser) parseNestedTypeFieldsWithoutNames(firstIdent *Ident) ([]Expr, error) {
Copy link
Member

@git-hulk git-hulk Jan 26, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

firstIdent => columnType

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@git-hulk git-hulk git-hulk left review comments

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@rhino1998 @coveralls @git-hulk