Update QA tests to v1.0.16#1030
Open
hansott wants to merge 7 commits into
Open
Conversation
new URL(...) converts hostnames to punycode, but we want to report the human-readable unicode version in heartbeats.
![aikido-pr-checks[bot]](https://avatars.githubusercontent.com/in/898896?s=60&v=4){kind=small}
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
Config stores domain names as unicode (e.g. münchen.example.com), but new URL() converts hostnames to punycode. Add hostnameToUnicode helper and apply it in domain blocking and heartbeat reporting only, keeping normalizeHostname unchanged to avoid breaking SSRF detection.
teta2k
approved these changes
May 20, 2026
timokoessler
approved these changes
May 21, 2026
| } | ||
|
|
||
| hostname = normalizeHostname(hostname); | ||
| hostname = hostnameToUnicode(normalizeHostname(hostname)); |
Member
There was a problem hiding this comment.
In a lot of places we are doing the opposite thing tho 😅
new URL("https://tkössler.de")
URL {
href: 'https://xn--tkssler-b1a.de/',
origin: 'https://xn--tkssler-b1a.de',
protocol: 'https:',
username: '',
password: '',
host: 'xn--tkssler-b1a.de',
hostname: 'xn--tkssler-b1a.de',
port: '',
pathname: '/',
search: '',
searchParams: URLSearchParams {},
hash: ''
}
>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary by Aikido
🚀 New Features
⚡ Enhancements
More info