Skip to content

Conversation

@sawenzel
Copy link
Collaborator

Fixes smaller issues introduced with the hybrid generator refactoring:

  • Make sure that internal configuration object is never null; In fact, it does not need to be a pointer.

  • Make sure the internal configuration struct is initialized from the GeneratorPythia8Param configurable when using the default constructor.

This commit fixes an issue/segfault when running the following command

o2-sim-dpl-eventgen --generator external --nEvents 200 --aggregate-timeframe 10000 --configFile ${O2DPG_ROOT}/MC/config/ALICE3/ini/pythia8_pp_136tev.ini -b

(which defaults constructs a Pythia8 generator)

Fixes smaller issues introduced with the hybrid generator
refactoring:

- Make sure that internal configuration object is never null;
  In fact, it does not need to be a pointer.

- Make sure the internal configuration struct is initialized
  from the GeneratorPythia8Param configurable when using the
  default constructor.

This commit fixes an issue/segfault when running the following command

o2-sim-dpl-eventgen --generator external --nEvents 200 --aggregate-timeframe 10000 --configFile ${O2DPG_ROOT}/MC/config/ALICE3/ini/pythia8_pp_136tev.ini -b

(which defaults constructs a Pythia8 generator)
@sawenzel sawenzel requested a review from jackal1-66 as a code owner November 21, 2024 15:38
@github-actions
Copy link
Contributor

REQUEST FOR PRODUCTION RELEASES:
To request your PR to be included in production software, please add the corresponding labels called "async-" to your PR. Add the labels directly (if you have the permissions) or add a comment of the form (note that labels are separated by a ",")

+async-label <label1>, <label2>, !<label3> ...

This will add <label1> and <label2> and removes <label3>.

The following labels are available
async-2023-pbpb-apass4
async-2023-pp-apass4
async-2024-pp-apass1
async-2022-pp-apass7
async-2024-pp-cpass0
async-2024-PbPb-cpass0
async-2024-PbPb-apass1
async-2024-ppRef-apass1

@alibuild
Copy link
Collaborator

Error while checking build/O2/fullCI for c8289a5 at 2024-11-21 17:59:

## sw/BUILD/O2-latest/log
c++: error: unrecognized command-line option '--rtlib=compiler-rt'
c++: error: unrecognized command-line option '--rtlib=compiler-rt'

Full log here.

@sawenzel sawenzel merged commit 929bb79 into AliceO2Group:dev Nov 21, 2024
8 checks passed
@alcaliva alcaliva added the async-2024-pp-apass1 Request porting to async-2024-pp-apass1 label Jan 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

async-2024-pp-apass1 Request porting to async-2024-pp-apass1

Development

Successfully merging this pull request may close these issues.

4 participants