Skip to content

ZDC: Delete unused files#15028

Open
vkucera wants to merge 1 commit intoAliceO2Group:devfrom
vkucera:unused-zdc
Open

ZDC: Delete unused files#15028
vkucera wants to merge 1 commit intoAliceO2Group:devfrom
vkucera:unused-zdc

Conversation

@vkucera
Copy link
Collaborator

@vkucera vkucera commented Feb 5, 2026

See #14973

@github-actions
Copy link
Contributor

github-actions bot commented Feb 5, 2026

REQUEST FOR PRODUCTION RELEASES:
To request your PR to be included in production software, please add the corresponding labels called "async-" to your PR. Add the labels directly (if you have the permissions) or add a comment of the form (note that labels are separated by a ",")

+async-label <label1>, <label2>, !<label3> ...

This will add <label1> and <label2> and removes <label3>.

The following labels are available
async-2023-pbpb-apass4
async-2023-pp-apass4
async-2024-pp-apass1
async-2022-pp-apass7
async-2024-pp-cpass0
async-2024-PbPb-apass1
async-2024-ppRef-apass1
async-2024-PbPb-apass2
async-2023-PbPb-apass5

@vkucera
Copy link
Collaborator Author

vkucera commented Feb 11, 2026

@coppedis Can you please fix your write permissions in the repository? It's not possible to request your review otherwise.

@ktf
Copy link
Member

ktf commented Feb 11, 2026

@coppedis I have invited you as writer to the repository. Please accept the invitation and review this PR (or close it).

@alibuild
Copy link
Collaborator

alibuild commented Feb 12, 2026

Error while checking build/O2/fullCI_slc9 for 1f89d1f at 2026-02-18 08:56:

http://madgraph.phys.ucl.ac.be//Downloads/HEPToolsInstaller/HEPToolsInstaller_V168.tar.gz
Now installing madanalysis5. Be patient...
/sw/BUILD/f582e4ec92cdbf97225eeb9801743861f47a6049/madgraph/HEPTools/HEPToolsInstallers/HEPToolInstaller.py:650: DeprecationWarning: distutils Version classes are deprecated. Use packaging.version instead.
  _mg5_version = LooseVersion(out[0])
/sw/BUILD/f582e4ec92cdbf97225eeb9801743861f47a6049/madgraph/HEPTools/HEPToolsInstallers/HEPToolInstaller.py:543: DeprecationWarning: distutils Version classes are deprecated. Use packaging.version instead.
  if tool_name in ['lhapdf6', 'lhapdf'] and MG5_version and MG5_version < LooseVersion("2.6.1"):
/sw/BUILD/f582e4ec92cdbf97225eeb9801743861f47a6049/madgraph/HEPTools/HEPToolsInstallers/HEPToolInstaller.py:298: DeprecationWarning: distutils Version classes are deprecated. Use packaging.version instead.
  ( lambda MG5version: MG5version < LooseVersion("2.6.1"),
Detected 'madanalysis5' missing dependency: 'zlib'. Will install it now.
Fetching data with command:
  wget --no-check-certificate http://www.zlib.net//zlib-1.3.1.tar.gz
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed

  0     0    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--     0
  0     0    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--     0
curl: (22) The requested URL returned error: 404 Not Found
Could not download data at '['http://www.zlib.net//zlib-1.3.1.tar.gz', 'http://madgraph.phys.ucl.ac.be/Downloads//zlib-1.3.1.tar.gz', 'http://madgraph.physics.illinois.edu/Downloads/zlib-1.3.1.tar.gz']' because of:


�[1;34mDefault installation of Madanalys5 failed.�[0m
�[1;34mMG5aMC will now attempt to reinstall it with the options '--no_MA5_further_install --no_root_in_MA5'.�[0m
�[1;34mThis will however limit MA5 applicability for hadron-level analysis.�[0m
�[1;34mIf you would like to prevent MG5aMC to re-attempt MA5 installation, start MG5aMC with './bin/mg5_aMC --debug'.�[0m
Downloading the HEPToolInstaller at:
   http://madgraph.phys.ucl.ac.be//Downloads/HEPToolsInstaller/HEPToolsInstaller_V168.tar.gz
�[1;31mCommand "import /sw/BUILD/f582e4ec92cdbf97225eeb9801743861f47a6049/madgraph/install.dat" interrupted in sub-command:
"install MadAnalysis5" with error:
RecursionError : maximum recursion depth exceeded in comparison
Please report this bug on https://bugs.launchpad.net/mg5amcnlo
More information is found in 'MG5_debug'.
Please attach this file to your report.�[0m
Checking if MG5 is up-to-date... (takes up to 5s)
New Version of MG5 available! Do you want to update your current version? [�[4mn�[0m, y]
�[1mThe answer to the previous question is not set in your input file�[0m
�[1mUse n value�[0m
Update bypassed.
The next check for a new version will be performed in 7 days
In order to change this delay. Enter the command:
set auto_update X
Putting X to zero will prevent this check at anytime.
You can upgrade your version at any time by typing:
install update
quit
++ rm install.dat
++ rm HEPTools/ninja/ninja_install.log
++ rm HEPTools/oneloop/oneloop_install.log
++ rm HEPTools/collier/collier_install.log
++ rm HEPTools/madanalysis5/madanalysis5_install.log
rm: cannot remove 'HEPTools/madanalysis5/madanalysis5_install.log': No such file or directory

Full log here.

@vkucera vkucera requested a review from coppedis February 12, 2026 19:20
@coppedis coppedis closed this Feb 13, 2026
@vkucera
Copy link
Collaborator Author

vkucera commented Feb 13, 2026

@coppedis Can you please comment on why you closed the PR?

@vkucera
Copy link
Collaborator Author

vkucera commented Feb 17, 2026

@coppedis Ping

@coppedis
Copy link
Collaborator

I don't know why this PR is assigned to me as reviewer. I din't commit nor modify the files marked for deletion here. You should most probably ask to @cortesep . Honestly, I am really busy in this period and I can't help much on this.

@vkucera
Copy link
Collaborator Author

vkucera commented Feb 17, 2026

I don't know why this PR is assigned to me as reviewer. I din't commit nor modify the files marked for deletion here. You should most probably ask to @cortesep . Honestly, I am really busy in this period and I can't help much on this.

Currently, you are the only code owner of the ZDC code in this repository.

/DataFormats/Detectors/ZDC @coppedis

/Detectors/ZDC @coppedis

That means that you are the only person responsible for reviewing pull requests in the relevant directories. If this is a mistake, please contact the relevant people and ask them to fix it.

@vkucera vkucera reopened this Feb 17, 2026
@github-actions
Copy link
Contributor

REQUEST FOR PRODUCTION RELEASES:
To request your PR to be included in production software, please add the corresponding labels called "async-" to your PR. Add the labels directly (if you have the permissions) or add a comment of the form (note that labels are separated by a ",")

+async-label <label1>, <label2>, !<label3> ...

This will add <label1> and <label2> and removes <label3>.

The following labels are available
async-2023-pbpb-apass4
async-2023-pp-apass4
async-2024-pp-apass1
async-2022-pp-apass7
async-2024-pp-cpass0
async-2024-PbPb-apass1
async-2024-ppRef-apass1
async-2024-PbPb-apass2
async-2023-PbPb-apass5

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

Comments