Skip to content

[O2B-1485] Send to the service EOR reason list only if one is added#2014

Merged
graduta merged 2 commits into
mainfrom
improv/O2B-1485/add-eor-only-if-there-is-one
Nov 17, 2025
Merged

[O2B-1485] Send to the service EOR reason list only if one is added#2014
graduta merged 2 commits into
mainfrom
improv/O2B-1485/add-eor-only-if-there-is-one

Conversation

@graduta
Copy link
Copy Markdown
Member

@graduta graduta commented Nov 17, 2025

I have a JIRA ticket

  • branch and/or PR name(s) include(s) JIRA ID
  • issue has "Fix version" assigned
  • issue "Status" is set to "In review"
  • PR labels are selected

Notable changes for users:

  • Fixes a bug in which the EOR reason would be deleted if the user adds it during the transition of STOP_ACTIVITY
  • Updates eor reason to clearly differentiate between the automatic one added and user one

Notable changes for developers:

  • EOR reason list should be sent to service only of one EOR reason is added

Changes made to the database:

  • NA

@graduta graduta self-assigned this Nov 17, 2025
@codecov
Copy link
Copy Markdown

codecov Bot commented Nov 17, 2025

Codecov Report

❌ Patch coverage is 0% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 45.48%. Comparing base (a50030e) to head (7f66e34).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
lib/server/kafka/AliEcsSynchronizer.js 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2014   +/-   ##
=======================================
  Coverage   45.47%   45.48%           
=======================================
  Files        1021     1021           
  Lines       17022    17023    +1     
  Branches     3081     3082    +1     
=======================================
+ Hits         7741     7743    +2     
+ Misses       9281     9280    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@graduta graduta merged commit 19fcd17 into main Nov 17, 2025
22 of 24 checks passed
@graduta graduta deleted the improv/O2B-1485/add-eor-only-if-there-is-one branch November 17, 2025 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Development

Successfully merging this pull request may close these issues.

1 participant