Skip to content

Improve docs on colliding bunches #2015

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
graduta merged 3 commits into from
Nov 17, 2025
Merged

Improve docs on colliding bunches #2015

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
74506bf
Improve docs on colliding bunches
graduta Nov 17, 2025
8067652
Add source of deliveredLumi
graduta Nov 17, 2025
5dd63d8
Merge branch 'main' of github.com:AliceO2Group/Bookkeeping into doc/a…
graduta Nov 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions lib/database/adapters/RunAdapter.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,12 @@ const { PhysicalConstant } = require('../../domain/enums/PhysicalConstant');

/**
* Extract number of colliding LHC bunch crossing (for ALICE) from LHC fill schema
* Normally this information should be retrieved from LHC Interface,
* but in case it is not available we try to extract it from the filling schema name
* using the convention, where we are interested in the AliceBunches:
* @example
* {a}_{totalBunches}_{CMS&AtlasBunches}_{AliceBunches}_{...}
* Example: "100ns_432b_374_250_181_28bpi_27inj_VdMPbPb" => 250 colliding bunch crossings for ALICE
* @param {string} fillingSchema filling schema
* @return {number} number of colliding LHC bunch crossing
*/
Expand Down
4 changes: 2 additions & 2 deletions lib/database/models/typedefs/SequelizeLhcFill.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,8 +20,8 @@
* @property {number|null} stableBeamsDuration
* @property {string|null} beamType
* @property {string|null} fillingSchemeName
* @property {number|null} collidingBunchesCount
* @property {number|null} deliveredLuminosity
* @property {number|null} collidingBunchesCount - property sent by LHC Interface
* @property {number|null} deliveredLuminosity - property sent by LHC Interface
* @property {string} createdAt
* @property {string} updatedAt
* @property {SequelizeLhcFillStatistics|null} statistics
Expand Down
Loading