send JSON object in body instead of uploading edited recipe#174
Draft
send JSON object in body instead of uploading edited recipe#174
Conversation
|
* set retention for job status to 30 days, update job status timestamp on read, and misc bug fixes * code cleanup
* remove irrelevant gradient data from final recipe string * round radius to 2 decimal points * update test file to remove unnecessary gradients * copilot suggestions
ascibisz
force-pushed
the
feature/pass-json-recipe
branch
from
00f3d24 to
38be27f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
In an effort to improve the efficiency of our packings, we want to remove the step where we're posting the edited recipe to firebase from the client and instead send the edited recipe JSON to the server in the body of the POST request, and then the server will handle any necessary firebase interactions.
Part of this ticket
Solution
This PR sends the edited recipe in the body of the POST request.
WARNING: Right now, this is just for use with testing!! We need the server to be able to read the recipe from the body of the request before we can merge this!!