Conversation
…nto feature/share-button
Coverage Report
File Coverage
|
||||||||||||||||||||||||||||||||||||||||||||
|
…nto feature/share-button
src/components/StatusBar/index.tsx
Outdated
| import DownloadIcon from "../../assets/download.svg?react"; | ||
| import ShareIcon from "../../assets/share.svg?react"; |
There was a problem hiding this comment.
with vite-plugin-svgr, we treat svgs as react components, so styles (e.g. stroke="currentColor") inherit correctly
There was a problem hiding this comment.
If/when the designs match it can also be convenient to use the antd icons directly:
https://ant.design/components/icon
But in this case the download icon looks a little diffferent.
interim17
left a comment
There was a problem hiding this comment.
Left a couple questions but I think they are non-blocking.
src/components/StatusBar/index.tsx
Outdated
| import DownloadIcon from "../../assets/download.svg?react"; | ||
| import ShareIcon from "../../assets/share.svg?react"; |
There was a problem hiding this comment.
If/when the designs match it can also be convenient to use the antd icons directly:
https://ant.design/components/icon
But in this case the download icon looks a little diffferent.
|
switched to using antd icons (removed two svg files, uninstalled @thao-do the download icon is slightly different from the design, would love to hear what you think;) |
|
update:
|

Problem
What is the problem this work solves, including
closes #173
Solution
What I/we did to solve this problem
added aSharelink to the navbarclicking
Shareopens an antd modal displaying the copiable URLupdates
following feedback from @thao-do:
Sharebutton to the bottom Status bar matching the design)Sharebutton follows the same behavior asDownload packing resultbuttonShare packing resultas suggestednote: the button color isn't quite matching the design yet, we're planning to do a broader color alignment in a follow-up ticket #183
next steps:
Download packing resultbutton for example recipes #182Type of change
Please delete options that are not relevant.