Skip to content

fix issue with template inst float mismatch in slice#1660

Merged
cyrush merged 1 commit intodevelopfrom
task/2026_02_cuda_12_9_fix
Feb 5, 2026
Merged

fix issue with template inst float mismatch in slice#1660
cyrush merged 1 commit intodevelopfrom
task/2026_02_cuda_12_9_fix

Conversation

@cyrush
Copy link
Copy Markdown
Member

@cyrush cyrush commented Feb 2, 2026

resolves #1659

@cyrush
Copy link
Copy Markdown
Member Author

cyrush commented Feb 2, 2026

@nicolemarsaglia this appears to resolve #1659 , which was reported by a user.

It checks the underlying type to a template type mismatched copy.

That said -- if we actually hit a case with mismatched types it seems like both the old an new path would fail.

I think we may be compiling combos some how that aren't used in practice, might be the nature of the viskores cast and call infrastructure.

I think we should look into if there are better ways to do this with viskores, we may be able to remove some of this code.

@cyrush cyrush merged commit 67d8934 into develop Feb 5, 2026
19 checks passed
@cyrush cyrush deleted the task/2026_02_cuda_12_9_fix branch February 5, 2026 23:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

slice filter build failure with cuda 12.9.1

1 participant