fix issue with template inst float mismatch in slice#1660
Merged
Conversation
Member
Author
|
@nicolemarsaglia this appears to resolve #1659 , which was reported by a user. It checks the underlying type to a template type mismatched copy. That said -- if we actually hit a case with mismatched types it seems like both the old an new path would fail. I think we may be compiling combos some how that aren't used in practice, might be the nature of the viskores cast and call infrastructure. I think we should look into if there are better ways to do this with viskores, we may be able to remove some of this code. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
resolves #1659