Eemeli/enhancement/616 custom comic reader modal#635
Conversation
…ntation, made changes to the GalleryCategoriesWithModalSlider component to manage modal state with React.
…-custom-comic-reader-modal
…d desktop 2-page and mobile 1-page layouts, numbering now works correctly on mobile, image sizing improved in modal, touch swipe support for mobile added.
Rutjake
left a comment
There was a problem hiding this comment.
Great work! Apologies for the delay in reviewing this. The comic should enlarge when clicked to ensure a smooth user experience. To wrap up the page updates, it would be great if you could also use the correct icons and ensure they are in the right positions.
frontend-next-migration/.gitignore
Outdated
| # local env files | ||
| .env*.local | ||
| .env | ||
| .env.* |
There was a problem hiding this comment.
No changes needed to .gitignore, as it already covers our environment files.
There was a problem hiding this comment.
There were some issues with pushing at one point, caused by git trying to push secrets for some unknown reason despite .gitignore, I’ll remove it going forward 👍
…licking on the comic, and closed by clicking on the backdrop.
Skoivumaki
left a comment
There was a problem hiding this comment.
Great work! Did not find any major issues, but could add fix for following:
Since the enlarged modals size is determined by window width, in odd aspect-ratio cases the modal will remain very small and hard to read. (see example. 4k monitor)
@Rutjake Modal works great, but now we can see the pages changing on the background. We could enhance this more, since the initial "pages on the page" loses its meaning with this modal thing?
📄 Pull Request Overview
Closes #616
🔧 Changes Made
Replaced Fancybox with a custom ReaderModal and implemented a comic reader with navigation, slider, responsive layouts (desktop 2-page / mobile 1-page), and touch swipe support.
Removed legacy Fancybox-related logic and simplified modal handling to use React state and the HTML5 element.
✅ Checklist Before Submission
console.log()or other debugging statements are left. ✅📝 Additional Information
Provide any additional context or information that reviewers may need to know:
The current gallery component serves as a working reference implementation, while the ReaderModal is fully reusable and intended for use in the upcoming redesigned page.
Dependencies:
No new dependencies introduced; Fancybox removed.
Known Issues:
The current gallery component is a feature-specific implementation and serves as a reference for the upcoming page refactor.