25.3.8-fips: add TLSv1.3 support to disableProtocols configuration#1569
Open
mkmkme wants to merge 2 commits intoreleases/25.3.8-fipsfrom
Open
25.3.8-fips: add TLSv1.3 support to disableProtocols configuration#1569mkmkme wants to merge 2 commits intoreleases/25.3.8-fipsfrom
mkmkme wants to merge 2 commits intoreleases/25.3.8-fipsfrom
Conversation
The disableProtocols mechanism only handled sslv2 through tlsv1_2. Specifying "tlsv1_3" in the config was silently ignored, so TLS 1.3 connections could not be disabled. This matters for FIPS testing where we need to verify that disabling all protocols actually prevents all connections. Add PROTO_TLSV1_3 to the Protocols enum, handle SSL_OP_NO_TLSv1_3 in Context::disableProtocols(), and parse "tlsv1_3" in all four config readers (SSLManager, TLSHandler, PostgreSQLHandler, KeeperServer).
Collaborator
Author
|
AI audit note: This review comment was generated by AI (gpt-5.3-codex). Audit update for PR #1569 (TLSv1.3 support for disableProtocols): Confirmed defects: No confirmed defects in reviewed scope. Coverage summary: |
Collaborator
|
Previously failing regression tests involving disabling protocols now pass. Looks like Also ran AI Audit from my end. AI said "No confirmed defects in reviewed scope." :) Looks good to me! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The disableProtocols mechanism only handled sslv2 through tlsv1_2. Specifying "tlsv1_3" in the config was silently ignored, so TLS 1.3 connections could not be disabled. This matters for FIPS testing where we need to verify that disabling all protocols actually prevents all connections.
Add PROTO_TLSV1_3 to the Protocols enum, handle SSL_OP_NO_TLSv1_3 in Context::disableProtocols(), and parse "tlsv1_3" in all four config readers (SSLManager, TLSHandler, PostgreSQLHandler, KeeperServer).
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
add TLSv1.3 support to disableProtocols configuration
Documentation entry for user-facing changes
...
CI/CD Options
Exclude tests:
Regression jobs to run: