Antalya 26.3: Fix export task not being killed during s3 outage#1744
Open
zvonand wants to merge 1 commit intoantalya-26.3from
Open
Antalya 26.3: Fix export task not being killed during s3 outage#1744zvonand wants to merge 1 commit intoantalya-26.3from
zvonand wants to merge 1 commit intoantalya-26.3from
Conversation
Collaborator
|
oh yeah, that's an important one as well |
zvonand
force-pushed
the
feature/antalya-26.3/pr-1564
branch
3 times, most recently
from
b2b724d to
15d7cc1
Compare
…t_from_being_cancelled Fix export task not being killed during s3 outage
zvonand
force-pushed
the
feature/antalya-26.3/pr-1564
branch
from
15d7cc1 to
f5d52c7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
The drop table operation must signal cancellation to all background tasks and wait until they ack it. This is done checking the
is_cancelledflag at each pipeline iteration. If S3 is unreachable and s3_retries_attempt is big (by default, it is 500), the pipeline gets stuck deep in the AWS SDK and never gets a chance to check the signal / flag. Making the task "unkillable".This PR fixes it in a hackish way by overwriting the
query_is_cancelled_predicate, which is checked by the S3 client retry strategy uponShouldRetry(#1564 by @arthurpassos).CI/CD Options
Exclude tests:
Regression jobs to run:
Cherry-picked from #1564.
Documentation entry for user-facing changes
...