Open
Conversation
- Increase server startup timeouts for sanitizer builds - Increase job timeouts from 180 to 300 minutes - Add xfails for known bugs exposed by sanitizers - Skip benchmark tests with sanitizers (too slow) Co-authored-by: Cursor <cursoragent@cursor.com>
- aggregate_functions: increase receive_timeout/send_timeout to 900s for sanitizers - rbac: skip compiled expression cache tests (JIT disabled in sanitizers) Co-authored-by: Cursor <cursoragent@cursor.com>
- base_58: change Fail to Error (test has UnboundLocalError) - rbac: fix FFails format (tuple not list), combine ARM + sanitizer check - iceberg: skip iceberg engine tests with sanitizers (server unstable) Co-authored-by: Cursor <cursoragent@cursor.com>
MSAN builds are 10-20x slower and need more time for server startup. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Addresses test failures in UBSAN, ASAN, TSAN, and MSAN regression runs.
Changes
helpers/cluster.pywait_clickhouse_healthy(90→300s),start_clickhouse(60→300s)run-regression-high-performance.ymlaggregate_functions/regression.pysettings/regression.pyiceberg/regression.pyalter/regression.pybase_58/regression.pyontime_benchmark/benchmark.pyTest plan
Made with Cursor