Add filepath-helper script and add fixes to relative file paths#4
Open
DarkCat736 wants to merge 9 commits intomainfrom
Open
Add filepath-helper script and add fixes to relative file paths#4DarkCat736 wants to merge 9 commits intomainfrom
DarkCat736 wants to merge 9 commits intomainfrom
Conversation
Collaborator
Author
|
This pull request also includes the starting code for the chat application. Not intentional, but it also can't hurt |
DarkCat736
commented
Mar 1, 2025
Collaborator
Author
|
@NotDyamuh I need you to review this code |
Member
|
It should run properly on HTTPS as well. I'll check when I get home. |
Collaborator
Author
|
@NotDyamuh DO NOT merge this branch. I will make a new pull req this evening. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This new script creates a "filePathHelper" object that has a function "relativeToAbsolute()" that converts relative filepaths to absolute filepaths. I have also applied the code so that the google and chat window load properly when running on local host. I am making a pull request because I need Dyamuh to verify this works on the actual domain as well. Thanks!