Support injectable custom TokenStore#2
Open
lucasfischer wants to merge 1 commit into
Open
Conversation
Make the TokenStore protocol and FileTokenStore public, and add an optional tokenStore parameter to AmoreLicensing.init. This lets callers persist the license token in a backend the library does not own (for example, the Keychain or a shared container) so the token can be reached from contexts the default file store cannot serve, such as an app and its extensions. The parameter defaults to a FileTokenStore in Application Support, so existing callers are unaffected. Also documents the new public surface and curates it under a Token Storage topic in the DocC index. Co-authored-by: Dave Camp <dave@thinbits.com>
lucasfischer
force-pushed
the
public-token-store
branch
from
dd863f1 to
10454d2
Compare
|
Checked out this branch and hooked up my keychain store through the new API and it worked as expected. Thanks! |
Contributor
Author
|
Thank you for testing @atomicgeese. Will create a new release soon. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Make the TokenStore protocol and
FileTokenStorepublic, and add an optionaltokenStoreparameter toAmoreLicensing.initlike proposed by @atomicgeese in #1.This lets callers persist the license token in a backend the library does not own (for example, the Keychain or a shared container) so the token can be reached from contexts the default file store cannot serve, such as an app and its extensions. The parameter defaults to a FileTokenStore in Application Support, so existing callers are unaffected.
Also documents the new public surface and curates it under a Token Storage topic in the DocC index.