for sequences, account for nulls and zero#112
Open
jhere1 wants to merge 2 commits intoAnatolyUss:masterfrom
Open
for sequences, account for nulls and zero#112jhere1 wants to merge 2 commits intoAnatolyUss:masterfrom
jhere1 wants to merge 2 commits intoAnatolyUss:masterfrom
Conversation
AnatolyUss
reviewed
Sep 1, 2023
| const seqName: string = getSequenceName(tableName, columnName); | ||
| const sql = `SELECT SETVAL(\'"${conversion._schema}"."${seqName}"\', | ||
| (SELECT MAX("${columnName}") FROM "${conversion._schema}"."${tableName}"));`; | ||
| GREATEST( |
Owner
There was a problem hiding this comment.
@jhere1
In general - good catch!
The question is, shouldn't we set sequence value to zero if table is empty?
Contributor
Author
There was a problem hiding this comment.
Yeah, the nextval would have been 2. Setting sequence value to 0 would involve changing the sequence definition min value. Take a look at my latest commit. Think this is cleaner. it does what we want (have nextval be 1) by saying the value of 1 is not used yet.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
set sequence value to 1 if max(columnName) returns null or less than 1.