Skip to content

Update clipper.core.h Add three way comparison.#1086

Open
XRay3D wants to merge 1 commit intoAngusJohnson:mainfrom
XRay3D:main
Open

Update clipper.core.h Add three way comparison.#1086
XRay3D wants to merge 1 commit intoAngusJohnson:mainfrom
XRay3D:main

Conversation

@XRay3D
Copy link
Copy Markdown

@XRay3D XRay3D commented Apr 4, 2026

Needed to satisfy C++ 26 standard library concepts.

Needed to satisfy C++ 26 standard library concepts.
@AngusJohnson
Copy link
Copy Markdown
Owner

AngusJohnson commented Apr 8, 2026

Needed to satisfy C++ 26 standard library concepts.

I have a fairly limited understanding of C++, so I don't understand why this spaceship operator is necessary. The important comparison operators (==, !=) have already been implemented in the 2 classes you want to change. While I understand that a spaceship operator would also implement the less_than and greater_than operators, isn't it better for these remain unimplemented?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants