Conversation
Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
|
@codex review recent commits. 为什么deps里要删掉http bearer相关代码？以及对main的改动，由fileflash.main改为src.main是否合理？ |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 501bd5b4cb
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
|
||
| def main() -> None: | ||
| uvicorn.run("fileflash.main:app", host="0.0.0.0", port=8080, reload=False) | ||
| uvicorn.run("src.main:app", host="0.0.0.0", port=8080, reload=False) |
There was a problem hiding this comment.
The entrypoint now runs uvicorn.run("src.main:app", ...), but this repo’s ASGI app lives under fileflash.main (there is no src/main.py). In environments that start the service via the fileflash console script, startup will fail with ModuleNotFoundError: No module named 'src.main', so the API cannot boot.
Useful? React with 👍 / 👎.
| base_dir = Path(__file__).resolve().parents[1] | ||
| files: list[str] = [] | ||
| for name in (".env", ".env.local"): | ||
| path = base_dir / name |
There was a problem hiding this comment.
This helper now anchors env-file lookup at Path(__file__).resolve().parents[1], which points to app/src/fileflash rather than the project root (app). As a result, the standard app/.env is no longer discovered, so production/local settings like DATABASE_URL and JWT secrets can silently fall back to defaults or be missing, breaking startup and auth behavior.
Useful? React with 👍 / 👎.
- Agent workspace: add conversation history sidebar, move execution policy dropdown below input area, remove advanced settings popover - Fix file/star icons shrinking when filename is too long by adding flex-shrink: 0 to icon and star button elements across all views - Normalize star icon size from 14px to 16px in FileRow, FileTable, and FileItemsView for visual consistency
3 participants
从干净 develop 拉出的 ky 分支，合并 Agent 后端能力。