Skip to content

create minimalist conda env and update package version#2

Open
vickimzhang wants to merge 2 commits intomainfrom
vz-update-conda-yml
Open

create minimalist conda env and update package version#2
vickimzhang wants to merge 2 commits intomainfrom
vz-update-conda-yml

Conversation

@vickimzhang
Copy link
Copy Markdown
Member

@vickimzhang vickimzhang commented Dec 9, 2025

Summary by CodeRabbit

  • Chores
    • Released version 2.0.1 with updated package metadata.
    • Simplified and trimmed environment dependencies to a minimal, updated set for leaner configuration.
    • Updated transformer environment references from version 1 to version 2 for the affected models.

✏️ Tip: You can customize this high-level summary in your review settings.

@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Dec 9, 2025

Walkthrough

Replaced a large, explicit Conda environment with a minimal, updated dependency list (pysyncrosim=2.1.3, numpy=2.3.5, pandas=2.3.3, gdal=3.10.3, rasterio=1.4.3) and bumped package version to 2.0.1 while updating two transformers' condaEnvVersion to 2.

Changes

Cohort / File(s) Change Summary
Environment dependencies
src/helloworldPy.yml
Removed a long, explicit list of channels, prefix and many packages; added a concise set: pysyncrosim=2.1.3, numpy=2.3.5, pandas=2.3.3, gdal=3.10.3, rasterio=1.4.3.
Package metadata
src/package.xml
Bumped package version from 2.0.02.0.1. Updated transformer elements firstModel and secondModel condaEnvVersion from 12.

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately summarizes the two main changes: creating a minimalist conda environment (removing extensive dependencies and keeping only essential packages) and updating the package version from 2.0.0 to 2.0.1.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch vz-update-conda-yml

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 84d93e2 and 1effd48.

📒 Files selected for processing (1)
  • src/helloworldPy.yml (1 hunks)
🔇 Additional comments (3)
src/helloworldPy.yml (3)

6-10: ✅ Critical dependencies now present—addresses previous review feedback.

The minimalist environment now explicitly includes rasterio, gdal, and numpy, which directly resolves the critical issue flagged in the previous review. These packages are required by model.py and model2.py and must be present in the environment.


6-10: numpy 2.3.5 and pandas 2.3.3 are compatible. Pandas 2.3.3 supports NumPy 2.x, and NumPy 2.3.5 is a stable bugfix release in the NumPy 2.x series. Note that third-party C-extension wheels compiled against NumPy 1.x may require rebuilding when used with NumPy 2.x.


6-10: Update package versions for compatibility with pysyncrosim 2.1.3.

The GDAL and rasterio versions are compatible, but pysyncrosim 2.1.3 has stricter dependency specifications:

  • pysyncrosim 2.1.3 is tested with numpy 2.1.0, not 2.3.5 (specified). The numpy 2.x series has breaking changes; verify numpy 2.3.5 compatibility with pysyncrosim.
  • pysyncrosim 2.1.3 specifies rasterio 1.3.10 (specified version is 1.4.3). While newer versions are likely compatible, confirm backward compatibility.
  • pandas 2.3.3 is acceptable (recommended is 2.2.2; both are in the 2.x series compatible with pysyncrosim).

Consider aligning numpy and rasterio with pysyncrosim's tested versions to avoid runtime failures, or verify through testing that the newer versions work as intended.


Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Copy Markdown

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

📜 Review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 9412010 and 84d93e2.

📒 Files selected for processing (2)
  • src/helloworldPy.yml (1 hunks)
  • src/package.xml (2 hunks)
🔇 Additional comments (2)
src/package.xml (2)

2-2: Version bump is appropriate; confirm it reflects the environment change scope.

The patch version bump (2.0.0 → 2.0.1) is proportional for environment simplification without API changes. However, ensure this messaging is clear to users, especially since the conda environment has changed significantly.


31-31: Verify condaEnvVersion bump requirement and document the breaking change.

Both transformers now reference condaEnvVersion="2", which signals a breaking change to the environment structure. This will invalidate prior environment caches on user machines. Confirm that:

  1. This version bump is the correct mechanism to signal the environment change to syncrosim.
  2. The Python scripts (model.py and model2.py) are fully compatible with the new minimal environment.
  3. Users are notified of the breaking change (e.g., via release notes or migration documentation).

If this is indeed a breaking change, consider adding a comment to the XML or release documentation explaining why the environment was simplified.

Also applies to: 38-38

@vickimzhang
Copy link
Copy Markdown
Member Author

before merge, just need to make sure that the Scenario.datasheet_raster() function is working in this package

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant