Update screenshot diff handling in CI workflow #682
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Modify the CI workflow to log screenshot diffs without failing the job.
Paget96
commented
Jan 19, 2026
Collaborator
Author
Paget96
left a comment
Paget96
left a comment
There was a problem hiding this comment.
CI workflow works
Collaborator
|
Sorry, with this PR the screenshot diff will not find/fail new generated screenshots, eg. on error case.
This (only) manual inspection will not happen. "It's green.... ok, lets merge" nobody will see it |
Collaborator
|
Please look here https://github.com/AppDevNext/AndroidChart/actions/runs/21118846579/job/60728472760?pr=665 Yes, it's annoying, but this is the goal. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modify the CI workflow to log screenshot diffs without failing the job.