Skip to content

Entry with double #684

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
hannesa2 wants to merge 3 commits into
base: master
Choose a base branch
from
Draft

Entry with double #684

hannesa2 wants to merge 3 commits into from

Conversation

@hannesa2
Copy link
Collaborator

@hannesa2 hannesa2 commented Jan 19, 2026 •
edited
Loading

It's #674 again which was merged too fast, reverted and now created again.

Using a generic in in my opinion the way to go.
Then everyone can decide which kind of precision he wants to use.

@hannesa2 hannesa2 added the enhancement New feature or request label Jan 19, 2026
@hannesa2 hannesa2 marked this pull request as draft January 19, 2026 05:33
@hannesa2
Copy link
Collaborator Author

hannesa2 commented Jan 19, 2026

Making this fully generic is complex because:

  • The Canvas drawing APIs require Float values
  • We need to convert between generic N : Number and Float for drawing
  • Arithmetic operations don't work directly on generic Number types

@hannesa2
Copy link
Collaborator Author

hannesa2 commented Jan 19, 2026

Screenshot differs: emulatorApi=9 with 5 screenshot(s)

setpoint (old) | diff | actual screenshot (new)

StartTest_smokeTestStart-38-LineChartTimeActivity-Hourly-2menu-click-11ToggleFilled.pngscreenshot

StartTest_smokeTestStart-38-LineChartTimeActivity-Hourly-2menu-click-12ToggleCircles.pngscreenshot

StartTest_smokeTestStart-38-LineChartTimeActivity-Hourly-2menu-click-1ToggleValues.pngscreenshot

StartTest_smokeTestStart-38-LineChartTimeActivity-Hourly-2menu-click-4ToggleIcons.pngscreenshot

StartTest_smokeTestStart-7-PerformanceLineChart-Performance-1SampleClick.pngscreenshot

@hannesa2
Copy link
Collaborator Author

hannesa2 commented Jan 19, 2026

Screenshot differs: emulatorApi=9 with 1 screenshot(s)

setpoint (old) | diff | actual screenshot (new)

StartTest_smokeTestStart-43-TimeLineActivity-Timeline-1SampleClick.pngscreenshot

@hannesa2
Copy link
Collaborator Author

hannesa2 commented Jan 19, 2026

Screenshot differs: emulatorApi=9 with 1 screenshot(s)

setpoint|diff|actual screenshot

StartTest_smokeTestStart-43-TimeLineActivity-Timeline-1SampleClick.pngscreenshot

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

enhancement New feature or request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@hannesa2