Open
Conversation
asymmetric
force-pushed
the
fix/normalize-nil-deref-on-numeric-key
branch
from
bb1a9a3 to
14fb598
Compare
… is compared to a number The five `Normalize()` methods on `Equality`, `LessThan`, `LessOrEqualThan`, `GreaterThan`, and `GreaterOrEqualThan` all assumed that when the variable is `$key`, `$owner`, or `$creator`, `Value.String` is non-nil. The grammar allows a bare number (e.g. `$key = 0`) to parse successfully, leaving `Value.String` nil and causing a panic on `strings.ToLower(*e.Value.String)`. Guard each site with a nil check; if the value is a number there is nothing to lowercase so we return `e` unchanged. Also adds the fuzz corpus entry and the `FuzzParse` harness that surfaced this. ## Testing Reproduce the specific panic that existed before this fix: ``` go test -run=FuzzParse/key_equals_number ./query/ ``` Run the full fuzz harness to catch similar regressions: ``` go test -fuzz=FuzzParse -fuzztime=60s ./query/ ``` Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
asymmetric
force-pushed
the
fix/normalize-nil-deref-on-numeric-key
branch
from
14fb598 to
e25d60d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The five
Normalize()methods onEquality,LessThan,LessOrEqualThan,GreaterThan, andGreaterOrEqualThanall assumed that when the variable is$key,$owner, or$creator,Value.Stringis non-nil. The grammar allows abare number (e.g.
$key = 0) to parse successfully, leavingValue.Stringnil and causing a panic on
strings.ToLower(*e.Value.String).Guard each site with a nil check; if the value is a number there is nothing
to lowercase so we return
eunchanged.Also adds the fuzz corpus entry and the
FuzzParseharness that surfaced this.Testing
Reproduce the specific panic that existed before this fix:
Run the full fuzz harness to catch similar regressions: