Skip to content

fix: stop managing pod docs templates#159

Merged
thomasgarrison merged 1 commit intomainfrom
vector/remove-managed-pod-doc-templates
May 1, 2026
Merged

fix: stop managing pod docs templates#159
thomasgarrison merged 1 commit intomainfrom
vector/remove-managed-pod-doc-templates

Conversation

@vector-arrow
Copy link
Copy Markdown
Contributor

@vector-arrow vector-arrow commented May 1, 2026

Summary

  • remove managed docs/ADRs/template-adr.md from pod project repos
  • remove managed docs/meetings/template-meeting.md from pod project repos

Why

These templates are useful when a repo is first created, but managing them forever means Terraform recreates the ADRs and meetings folders after a project intentionally deletes them.

Validation

  • terraform fmt -check -recursive . could not be run locally because Terraform is not installed on this host
  • change is a straight deletion from local.pod-projects.files only

@vector-arrow vector-arrow requested a review from a team as a code owner May 1, 2026 19:14
@cla-bot cla-bot Bot added the cla-signed label May 1, 2026
@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 1, 2026

Terraform Format and Style 🖌success

Terraform Initialization ⚙️success

Terraform Validation 🤖success

Validation Output
Success! The configuration is valid.


Terraform Plan 📖success

Show Plan
terraform

Terraform used the selected providers to generate the following execution
plan. Resource actions are indicated with the following symbols:
  + create
  ~ update in-place
  - destroy

Terraform will perform the following actions:

  # module.repository_pod["caribou"].github_repository_file.files["docs/ADRs/template-adr.md"] will be destroyed
  # (because key ["docs/ADRs/template-adr.md"] is not in for_each map)
  - resource "github_repository_file" "files" {
      - branch              = "main" -> null
      - commit_message      = <<-EOT
            fixup! ci: terraform provisioned file changes
            
            [skip ci]
        EOT -> null
      - commit_sha          = "06e9f4d9c46272426aff01957dcbcec9db659899" -> null
      - file                = "docs/ADRs/template-adr.md" -> null
      - id                  = "project-caribou/docs/ADRs/template-adr.md" -> null
      - overwrite_on_create = true -> null
      - ref                 = "main" -> null
      - repository          = "project-caribou" -> null
      - sha                 = "e69de29bb2d1d6434b8b29ae775ad8c2e48c5391" -> null
    }

  # module.repository_pod["caribou"].github_repository_file.files["docs/meetings/template-meeting.md"] will be destroyed
  # (because key ["docs/meetings/template-meeting.md"] is not in for_each map)
  - resource "github_repository_file" "files" {
      - branch              = "main" -> null
      - commit_message      = <<-EOT
            fixup! ci: terraform provisioned file changes
            
            [skip ci]
        EOT -> null
      - commit_sha          = "9106ff6ba7407409876fd8567350a02efdf50803" -> null
      - file                = "docs/meetings/template-meeting.md" -> null
      - id                  = "project-caribou/docs/meetings/template-meeting.md" -> null
      - overwrite_on_create = true -> null
      - ref                 = "main" -> null
      - repository          = "project-caribou" -> null
      - sha                 = "e69de29bb2d1d6434b8b29ae775ad8c2e48c5391" -> null
    }

  # module.repository_pod["feather"].github_repository_file.files["docs/ADRs/template-adr.md"] will be destroyed
  # (because key ["docs/ADRs/template-adr.md"] is not in for_each map)
  - resource "github_repository_file" "files" {
      - branch              = "main" -> null
      - commit_message      = <<-EOT
            fixup! ci: terraform provisioned file changes
            
            [skip ci]
        EOT -> null
      - commit_sha          = "ce4d0b564882dbc722992a1ba25e3b5b721c8351" -> null
      - file                = "docs/ADRs/template-adr.md" -> null
      - id                  = "project-feather/docs/ADRs/template-adr.md" -> null
      - overwrite_on_create = true -> null
      - ref                 = "main" -> null
      - repository          = "project-feather" -> null
      - sha                 = "e69de29bb2d1d6434b8b29ae775ad8c2e48c5391" -> null
    }

  # module.repository_pod["feather"].github_repository_file.files["docs/meetings/template-meeting.md"] will be destroyed
  # (because key ["docs/meetings/template-meeting.md"] is not in for_each map)
  - resource "github_repository_file" "files" {
      - branch              = "main" -> null
      - commit_message      = <<-EOT
            fixup! ci: terraform provisioned file changes
            
            [skip ci]
        EOT -> null
      - commit_sha          = "c65813bfe0be376adad2fb6749b8eeea98b5cf36" -> null
      - file                = "docs/meetings/template-meeting.md" -> null
      - id                  = "project-feather/docs/meetings/template-meeting.md" -> null
      - overwrite_on_create = true -> null
      - ref                 = "main" -> null
      - repository          = "project-feather" -> null
      - sha                 = "e69de29bb2d1d6434b8b29ae775ad8c2e48c5391" -> null
    }

  # module.repository_pod["flight-tracking"].github_repository_file.files["docs/ADRs/template-adr.md"] will be destroyed
  # (because key ["docs/ADRs/template-adr.md"] is not in for_each map)
  - resource "github_repository_file" "files" {
      - branch              = "main" -> null
      - commit_message      = <<-EOT
            fixup! ci: terraform provisioned file changes
            
            [skip ci]
        EOT -> null
      - commit_sha          = "70131363dc4a1a5108bb54db71dae4a09df7374b" -> null
      - file                = "docs/ADRs/template-adr.md" -> null
      - id                  = "project-flight-tracking/docs/ADRs/template-adr.md" -> null
      - overwrite_on_create = true -> null
      - ref                 = "main" -> null
      - repository          = "project-flight-tracking" -> null
      - sha                 = "e69de29bb2d1d6434b8b29ae775ad8c2e48c5391" -> null
    }

  # module.repository_pod["flight-tracking"].github_repository_file.files["docs/meetings/template-meeting.md"] will be destroyed
  # (because key ["docs/meetings/template-meeting.md"] is not in for_each map)
  - resource "github_repository_file" "files" {
      - branch              = "main" -> null
      - commit_message      = <<-EOT
            fixup! ci: terraform provisioned file changes
            
            [skip ci]
        EOT -> null
      - commit_sha          = "b59d283fbb989c0293e3322b38ba89414e8f6d34" -> null
      - file                = "docs/meetings/template-meeting.md" -> null
      - id                  = "project-flight-tracking/docs/meetings/template-meeting.md" -> null
      - overwrite_on_create = true -> null
      - ref                 = "main" -> null
      - repository          = "project-flight-tracking" -> null
      - sha                 = "e69de29bb2d1d6434b8b29ae775ad8c2e48c5391" -> null
    }

  # module.repository_pod["longshot"].github_branch_protection.all["**/**"] will be created
  + resource "github_branch_protection" "all" {
      + allows_deletions                = true
      + allows_force_pushes             = true
      + blocks_creations                = false
      + enforce_admins                  = true
      + id                              = (known after apply)
      + lock_branch                     = false
      + pattern                         = "**/**"
      + repository_id                   = "project-longshot"
      + require_conversation_resolution = false
      + require_signed_commits          = true
      + required_linear_history         = false
    }

  # module.repository_pod["longshot"].github_repository_file.files["docs/ADRs/template-adr.md"] will be destroyed
  # (because key ["docs/ADRs/template-adr.md"] is not in for_each map)
  - resource "github_repository_file" "files" {
      - branch              = "main" -> null
      - commit_message      = <<-EOT
            fixup! ci: terraform provisioned file changes
            
            [skip ci]
        EOT -> null
      - commit_sha          = "ebc4b2496c303dbf6d33ab91577269c15af3ca08" -> null
      - file                = "docs/ADRs/template-adr.md" -> null
      - id                  = "project-longshot/docs/ADRs/template-adr.md" -> null
      - overwrite_on_create = true -> null
      - ref                 = "main" -> null
      - repository          = "project-longshot" -> null
      - sha                 = "e69de29bb2d1d6434b8b29ae775ad8c2e48c5391" -> null
    }

  # module.repository_pod["longshot"].github_repository_file.files["docs/meetings/template-meeting.md"] will be destroyed
  # (because key ["docs/meetings/template-meeting.md"] is not in for_each map)
  - resource "github_repository_file" "files" {
      - branch              = "main" -> null
      - commit_message      = <<-EOT
            fixup! ci: terraform provisioned file changes
            
            [skip ci]
        EOT -> null
      - commit_sha          = "7e95bf152be6f1de764f60e16a136d9843cd07ca" -> null
      - file                = "docs/meetings/template-meeting.md" -> null
      - id                  = "project-longshot/docs/meetings/template-meeting.md" -> null
      - overwrite_on_create = true -> null
      - ref                 = "main" -> null
      - repository          = "project-longshot" -> null
      - sha                 = "e69de29bb2d1d6434b8b29ae775ad8c2e48c5391" -> null
    }

  # module.repository_pod["quiver"].github_repository_file.files["docs/ADRs/template-adr.md"] will be destroyed
  # (because key ["docs/ADRs/template-adr.md"] is not in for_each map)
  - resource "github_repository_file" "files" {
      - branch              = "main" -> null
      - commit_message      = <<-EOT
            fixup! ci: terraform provisioned file changes
            
            [skip ci]
        EOT -> null
      - commit_sha          = "0d0ddda8ae705d5972ee28748fe6d57e150024a3" -> null
      - file                = "docs/ADRs/template-adr.md" -> null
      - id                  = "project-quiver/docs/ADRs/template-adr.md" -> null
      - overwrite_on_create = true -> null
      - ref                 = "main" -> null
      - repository          = "project-quiver" -> null
      - sha                 = "e69de29bb2d1d6434b8b29ae775ad8c2e48c5391" -> null
    }

  # module.repository_pod["quiver"].github_repository_file.files["docs/meetings/template-meeting.md"] will be destroyed
  # (because key ["docs/meetings/template-meeting.md"] is not in for_each map)
  - resource "github_repository_file" "files" {
      - branch              = "main" -> null
      - commit_message      = <<-EOT
            fixup! ci: terraform provisioned file changes
            
            [skip ci]
        EOT -> null
      - commit_sha          = "a9b702aacf87e3be77c4de86e933e57d191c61ae" -> null
      - file                = "docs/meetings/template-meeting.md" -> null
      - id                  = "project-quiver/docs/meetings/template-meeting.md" -> null
      - overwrite_on_create = true -> null
      - ref                 = "main" -> null
      - repository          = "project-quiver" -> null
      - sha                 = "e69de29bb2d1d6434b8b29ae775ad8c2e48c5391" -> null
    }

  # module.repository_pod["spearhead"].github_repository_file.files["docs/ADRs/template-adr.md"] will be destroyed
  # (because key ["docs/ADRs/template-adr.md"] is not in for_each map)
  - resource "github_repository_file" "files" {
      - branch              = "main" -> null
      - commit_message      = <<-EOT
            fixup! ci: terraform provisioned file changes
            
            [skip ci]
        EOT -> null
      - commit_sha          = "410c24047d9aeaa3d2ba382542563926cc9d3ada" -> null
      - file                = "docs/ADRs/template-adr.md" -> null
      - id                  = "project-spearhead/docs/ADRs/template-adr.md" -> null
      - overwrite_on_create = true -> null
      - ref                 = "main" -> null
      - repository          = "project-spearhead" -> null
      - sha                 = "e69de29bb2d1d6434b8b29ae775ad8c2e48c5391" -> null
    }

  # module.repository_pod["spearhead"].github_repository_file.files["docs/meetings/template-meeting.md"] will be destroyed
  # (because key ["docs/meetings/template-meeting.md"] is not in for_each map)
  - resource "github_repository_file" "files" {
      - branch              = "main" -> null
      - commit_message      = <<-EOT
            fixup! ci: terraform provisioned file changes
            
            [skip ci]
        EOT -> null
      - commit_sha          = "a7a242329503b7c13edca2d26418ec84981f9231" -> null
      - file                = "docs/meetings/template-meeting.md" -> null
      - id                  = "project-spearhead/docs/meetings/template-meeting.md" -> null
      - overwrite_on_create = true -> null
      - ref                 = "main" -> null
      - repository          = "project-spearhead" -> null
      - sha                 = "e69de29bb2d1d6434b8b29ae775ad8c2e48c5391" -> null
    }

  # module.repository_pod_template["project"].github_repository_file.files["docs/ADRs/template-adr.md"] will be destroyed
  # (because key ["docs/ADRs/template-adr.md"] is not in for_each map)
  - resource "github_repository_file" "files" {
      - branch              = "main" -> null
      - commit_message      = <<-EOT
            fixup! ci: terraform provisioned file changes
            
            [skip ci]
        EOT -> null
      - commit_sha          = "36f0e9113a4bfa53a3d9e7aacbf8c4ff37c20719" -> null
      - file                = "docs/ADRs/template-adr.md" -> null
      - id                  = "pod-template-project/docs/ADRs/template-adr.md" -> null
      - overwrite_on_create = true -> null
      - ref                 = "main" -> null
      - repository          = "pod-template-project" -> null
      - sha                 = "e69de29bb2d1d6434b8b29ae775ad8c2e48c5391" -> null
    }

  # module.repository_pod_template["project"].github_repository_file.files["docs/meetings/template-meeting.md"] will be destroyed
  # (because key ["docs/meetings/template-meeting.md"] is not in for_each map)
  - resource "github_repository_file" "files" {
      - branch              = "main" -> null
      - commit_message      = <<-EOT
            fixup! ci: terraform provisioned file changes
            
            [skip ci]
        EOT -> null
      - commit_sha          = "f2a684eb4cd29a76ecc21770a401380cb1e2c1c8" -> null
      - file                = "docs/meetings/template-meeting.md" -> null
      - id                  = "pod-template-project/docs/meetings/template-meeting.md" -> null
      - overwrite_on_create = true -> null
      - ref                 = "main" -> null
      - repository          = "pod-template-project" -> null
      - sha                 = "e69de29bb2d1d6434b8b29ae775ad8c2e48c5391" -> null
    }

  # module.repository_tf["onboarding"].github_repository.repository will be updated in-place
  ~ resource "github_repository" "repository" {
      ~ has_wiki                    = false -> true
        id                          = "tf-onboarding"
        name                        = "tf-onboarding"
        # (34 unchanged attributes hidden)
    }

Plan: 1 to add, 1 to change, 14 to destroy.

Pusher: @vector-arrow, Action: pull_request, Working Directory: ``, Workflow: Terraform

@thomasgarrison thomasgarrison merged commit 9feb729 into main May 1, 2026
5 checks passed
@thomasgarrison thomasgarrison deleted the vector/remove-managed-pod-doc-templates branch May 1, 2026 19:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants