Conversation
You mean saves power when sleep? Or when running? Can you explain a bit more when power is saved and for which components it is saved? Thanks! I will try this patch. |
yes |
So in both cases? |
WhatAmISupposedToPutHere
force-pushed
the
feldspar
branch
from
deb31cf to
b899989
Compare
jannau
left a comment
jannau
left a comment
There was a problem hiding this comment.
What is missing for submitting this upstream? just dt-bindings and rtkit rust abstractions or something else?
| }; | ||
|
|
||
| &pmp { | ||
| apple,pio-ranges = <0x2 0x80000000 0x0 0x1000000>, |
There was a problem hiding this comment.
This needs at least a comment that the order is important but it would hurt to find another way to ensure this
There was a problem hiding this comment.
Shouldn't that kind of comment go into the dt-binding?
We have rtkit, what does not exist (or did not exist when i was writing this one) is rust abstractions for iomap_at. And obviously testing on not-m1pro |
|
we have rtkit rust binding but upstream hasn't so we would have to submit rtkit first or with pmp |
WhatAmISupposedToPutHere
force-pushed
the
feldspar
branch
2 times, most recently
from
0012b02 to
0a5faee
Compare
Signed-off-by: Sasha Finkelstein <fnkl.kernel@gmail.com>
WhatAmISupposedToPutHere
force-pushed
the
feldspar
branch
from
0a5faee to
66193a9
Compare
This is the core part of a power management co-processor present on certain Apple SoCs. This driver starts the firmware, and uploads the configuration and calibration data by pretending to be IOKit. Signed-off-by: Sasha Finkelstein <fnkl.kernel@gmail.com>
This driver manages a shared SRAM area that is used to communicate desired power states of devices that PMP manages. Signed-off-by: Sasha Finkelstein <fnkl.kernel@gmail.com>
Add the PMP device and set it as the power-domain for devices that need to report their power states to it. Signed-off-by: Sasha Finkelstein <fnkl.kernel@gmail.com>
WhatAmISupposedToPutHere
force-pushed
the
feldspar
branch
from
66193a9 to
7c135f2
Compare
3 participants
Works on M1 Pro and saves about 1W of power there, will not work on vanilla M1 (that uses pmp v1, not v2), and hopefully should work on m1 max/ultra and m2 vanilla/pro/max/ultra.