feat: Implement configurable independent community sub-sites with modular navigation base on verl#111
Conversation
CLA Signature Passjustbin-coder, thanks for your pull request. All authors of the commits have signed the CLA. 👍 |
1 similar comment
CLA Signature Passjustbin-coder, thanks for your pull request. All authors of the commits have signed the CLA. 👍 |
389eddf to
86defb6
Compare
CLA Signature Passjustbin-coder, thanks for your pull request. All authors of the commits have signed the CLA. 👍 |
86defb6 to
2bd7f4a
Compare
CLA Signature Passjustbin-coder, thanks for your pull request. All authors of the commits have signed the CLA. 👍 |
2bd7f4a to
2b1830a
Compare
CLA Signature Passjustbin-coder, thanks for your pull request. All authors of the commits have signed the CLA. 👍 |
1 similar comment
CLA Signature Passjustbin-coder, thanks for your pull request. All authors of the commits have signed the CLA. 👍 |
9cd7dbc to
c0e794d
Compare
CLA Signature Passjustbin-coder, thanks for your pull request. All authors of the commits have signed the CLA. 👍 |
c0e794d to
f786fde
Compare
CLA Signature Passjustbin-coder, thanks for your pull request. All authors of the commits have signed the CLA. 👍 |
1 similar comment
CLA Signature Passjustbin-coder, thanks for your pull request. All authors of the commits have signed the CLA. 👍 |
4b63b32 to
5a2e814
Compare
CLA Signature Passjustbin-coder, thanks for your pull request. All authors of the commits have signed the CLA. 👍 |
5a2e814 to
48c102e
Compare
CLA Signature Passjustbin-coder, thanks for your pull request. All authors of the commits have signed the CLA. 👍 |
|
What's in _static/ascend_config.json, such a huge change |
There was a problem hiding this comment.
Thanks very much for bringing usability features to the Ascend/docs. Here are a few review comments for your reference.
In general, we prefer to maintain the original architecture of automated documentation builds without adding excessive local documentation. Ideally, the ./sources folder should only contain directory indexes for the documentation, which would significantly reduce maintenance overhead.
| @@ -0,0 +1,2 @@ | |||
|
|
|||
There was a problem hiding this comment.
These documentation files only contain include directives. Could this functionality be automated during the make stage—for example, by moving it into the Makefile?
There was a problem hiding this comment.
The documentation is now configured to reference the official upstream files directly
| @@ -0,0 +1,2 @@ | |||
|
|
|||
conf.py
Outdated
| # ones. | ||
| extensions = [ | ||
| 'recommonmark', | ||
| # 'recommonmark', |
There was a problem hiding this comment.
If it is confirmed that recommonmark is no longer needed, it can be removed directly.
conf.py
Outdated
| 'open_source_development': '🔧 开源开发' | ||
| } | ||
| }, | ||
| # 未来增加 sglang,只需在这里解除注释即可,不用改代码 |
There was a problem hiding this comment.
Following clean code practices, any temporarily unavailable feature should be deleted, not just commented out.
_static/ascend_config.json
Outdated
There was a problem hiding this comment.
It seems that ascend_config.json turns an automated documentation build into a local one. This approach introduces excessive code and is difficult to maintain. I recommend sticking with the original method.
48c102e to
ff7a1ae
Compare
CLA Signature Passjustbin-coder, thanks for your pull request. All authors of the commits have signed the CLA. 👍 |
1 similar comment
CLA Signature Passjustbin-coder, thanks for your pull request. All authors of the commits have signed the CLA. 👍 |
1e02772 to
4edd786
Compare
CLA Signature Passjustbin-coder, thanks for your pull request. All authors of the commits have signed the CLA. 👍 |
this large change in _static/ascend_config.json was triggered automatically after updating the Makefile. I have removed the file from the current commit and added it to .gitignore to keep the PR clean. i think it must to refactor the configuration writing logic in a future PR to prevent this issue. |
| <!-- 快速开始 --> | ||
| <h2 class="verl-section-title">🚀 快速开始</h2> | ||
| <div class="verl-quick-grid"> | ||
| <a href="../_generated/sources/verl/quick_start/ascend_quick_start.html" class="verl-quick-card"> |
sources/verl/index.rst
Outdated
| @@ -1,12 +1,247 @@ | |||
| verl | |||
| ============ | |||
| verl - 大模型强化学习训练框架 | |||
There was a problem hiding this comment.
建议去掉标题中的 ”大模型强化学习训练框架“ ,以便和目录中其他项目的名称保持一致。对项目所在应用领域的注解可在文档正文中给出。
4edd786 to
f88b189
Compare
CLA Signature Passjustbin-coder, thanks for your pull request. All authors of the commits have signed the CLA. 👍 |
CLA Signature Passjustbin-coder, thanks for your pull request. All authors of the commits have signed the CLA. 👍 |




verview
This PR introduces a generic, highly extensible solution for "independent community sub-sites". Using the
verlcommunity as the first use case, it achieves sidebar content isolation, modular navigation based on the developer journey, and dynamic extraction of in-page TOCs for long documents. Future communities can be onboarded seamlessly by simply updating a configuration dict without any code changes.Core Modifications
conf.py: Added theindependent_communitiesdictionary and anupdate_page_contexthook to intercept paths during build and dynamically inject community configs to the frontend._templates/layout.html: Utilized JS to dynamically reconstruct the DOM. It extracts the current community's directory tree, generates native-compliant category captions, and smartly elevates deep TOC levels to display inner headings._static/custom.css: Added dedicated styles for#independent-sidebar, perfectly inheriting the active highlights and collapsible interactions of the native Sphinx RTD theme.include) to resolve duplicate H1 conflicts and blank rendering issues.Testing & Effects
verlcommunity exclusively displays its own documents in the left sidebar, successfully hiding global unrelated content.