feature/rayon-like-parallel-execution#1
Merged
AsfhtgkDavid merged 4 commits intoFeb 22, 2026
Merged
Conversation
AsfhtgkDavid
requested changes
Feb 22, 2026
| impl<T: Runnable> ParallelRun for Vec<T> { | ||
| type Output = T::Output; | ||
|
|
||
| fn par_run(self) -> Vec<Self::Output> { |
Owner
There was a problem hiding this comment.
It's interesting, but I suggest creating two methods: the first returns Vec<JoinHandler> and is non-blocking, while the second calls the first and performs a join. This would provide more options for user.
Contributor
Author
There was a problem hiding this comment.
I though about it, but i dont know if this could work, because the results wouldnt be ordered and the user would have to sort it themselves.
Contributor
Author
|
I will make it |
Contributor
Author
|
It now returns a Result. I also added benchmarks. |
AsfhtgkDavid
requested changes
Feb 22, 2026
| let chunk_size = self.len().div_ceil(threads); | ||
|
|
||
| let mut iter = self.into_iter(); | ||
| let mut handles = Vec::new(); |
Owner
There was a problem hiding this comment.
Use Vec::with_capacity(threads)
| fn par_run(self) -> std::thread::Result<Vec<Self::Output>> { | ||
| let threads = std::thread::available_parallelism() | ||
| .map(|n| n.get()) | ||
| .unwrap_or(1); |
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It adds the trait
ParallelRun, which runs the tasks in parallel, without spawning a separate thread for each task.Example: