Skip to content

Bugfix doublequotes#7

Merged
gabrielpeter merged 12 commits intomasterfrom
bugfix-doublequotes
Mar 27, 2026
Merged

Bugfix doublequotes#7
gabrielpeter merged 12 commits intomasterfrom
bugfix-doublequotes

Conversation

@AbomDocPhibes
Copy link
Copy Markdown
Contributor

No description provided.

@AbomDocPhibes
Copy link
Copy Markdown
Contributor Author

control currently did not behave correctly when double quotes ("") were included in either a single response list, or in a JS file when using the ADC in an open ended loop.

main culprit was the single.html and open.html files where the input value being saved was not properly escaping problematic HTML values such as &, %, "", etc. Fix was made to properly catch and escape these values so the data could be visualized and saved via the JS element.

Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the AutoComplete ADC to better tolerate double quotes/special characters in suggestion values and initial input values, while bumping the packaged artifact/version metadata.

Changes:

  • Escape suggestion values when rendering data-* attributes and decode before consumption in auto-complete.js.
  • Rework single.html / open.html to pre-escape some values and populate the visible input’s value via a hidden text node + JS.
  • Bump version/date metadata and include an updated packaged bin/AutoComplete.adc.

Reviewed changes

Copilot reviewed 5 out of 6 changed files in this pull request and generated 9 comments.

Show a summary per file
File Description
resources/static/auto-complete.js Adds attribute escaping/decoding helpers and applies them to data-val / data-fullval.
resources/dynamic/single.html Adds “safe” variables + manual escaping; sets visible input value via hidden span + JS; duplicates window.value assignment.
resources/dynamic/open.html Similar escaping/value-population changes; window.value script emitted inside loop.
config.xml Version/date bump; minor whitespace change.
changelog.md Adds v3.3.0/v3.3.1 entries (with future dates + formatting/spelling issues).
bin/AutoComplete.adc Adds packaged ADC artifact (currently treated as text by git).

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@gabrielpeter gabrielpeter merged commit 764f9c2 into master Mar 27, 2026
5 checks passed
@AbomDocPhibes AbomDocPhibes deleted the bugfix-doublequotes branch March 30, 2026 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants