This repository was archived by the owner on Sep 28, 2023. It is now read-only.
Open
Conversation
Dinonard
reviewed
Jun 21, 2023
Collaborator
Dinonard
left a comment
There was a problem hiding this comment.
PR summary/message should be updated.
Dinonard
reviewed
Jun 29, 2023
Collaborator
Dinonard
left a comment
There was a problem hiding this comment.
I'd suggest to discuss the XTokens inclusion and its impact on the interface with the team.
| } | ||
|
|
||
| /** | ||
| * @dev Withdraw assets using PalletXCM call. |
Collaborator
There was a problem hiding this comment.
You shouldn't put implementation details into interface definition.
I see the old file also has this, but it's wrong.
PierreOssun
reviewed
Jul 10, 2023
Minimum allowed line rate is |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Summary
Changes
send_xcm()which allows to send any xcm-message to the destination chain.This addition helps in getting rid of function overloading for different Account types (AccountId32 and AccountKey20) supported by xcm.
Check list