Skip to content

Define slit transforms for image slicer IFUs and offset slits#922

Draft
oczoske wants to merge 2 commits into
mainfrom
oc/asymm_slit
Draft

Define slit transforms for image slicer IFUs and offset slits#922
oczoske wants to merge 2 commits into
mainfrom
oc/asymm_slit

Conversation

@oczoske
Copy link
Copy Markdown
Collaborator

@oczoske oczoske commented May 7, 2026

Description will follow.

@oczoske oczoske self-assigned this May 7, 2026
@oczoske oczoske added enhancement PR adding or improving a feature (use "Feature" type for issues (requests), not this label) effects Related to a ScopeSim effect spectroscopy Related to spectroscopic modes labels May 7, 2026
@codecov
Copy link
Copy Markdown

codecov Bot commented May 7, 2026

Codecov Report

❌ Patch coverage is 9.52381% with 19 lines in your changes missing coverage. Please review.
✅ Project coverage is 29.89%. Comparing base (39d4e0a) to head (e152938).
⚠️ Report is 11 commits behind head on main.

Files with missing lines Patch % Lines
scopesim/effects/spectral_trace_list.py 10.00% 9 Missing ⚠️
scopesim/effects/apertures.py 0.00% 7 Missing ⚠️
scopesim/effects/spectral_trace_list_utils.py 25.00% 3 Missing ⚠️

❗ There is a different number of reports uploaded between BASE (39d4e0a) and HEAD (e152938). Click for more details.

HEAD has 12 uploads less than BASE
Flag BASE (39d4e0a) HEAD (e152938)
14 2
Additional details and impacted files
@@             Coverage Diff             @@
##             main     #922       +/-   ##
===========================================
- Coverage   75.19%   29.89%   -45.31%     
===========================================
  Files          70       68        -2     
  Lines        9018     8865      -153     
===========================================
- Hits         6781     2650     -4131     
- Misses       2237     6215     +3978     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

effects Related to a ScopeSim effect enhancement PR adding or improving a feature (use "Feature" type for issues (requests), not this label) spectroscopy Related to spectroscopic modes

Projects

Status: No status

Development

Successfully merging this pull request may close these issues.

1 participant