Skip to content

ci: update workflow actions for Node 24 #98

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
zouyonghe merged 1 commit into from
Mar 19, 2026
+3 −2
Merged

ci: update workflow actions for Node 24 #98

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/actions/setup-desktop-build/action.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ runs:
node-version: ${{ inputs.node-version }}

- name: Setup pnpm
uses: pnpm/action-setup@v4.2.0
uses: pnpm/action-setup@v4.4.0
with:
version: ${{ inputs.pnpm-version }}

Expand Down
3 changes: 2 additions & 1 deletion .github/workflows/build-desktop-tauri.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,6 +38,7 @@ permissions:

env:
ASTRBOT_SOURCE_GIT_URL: ${{ vars.ASTRBOT_SOURCE_GIT_URL || 'https://github.com/AstrBotDevs/AstrBot.git' }}
FORCE_JAVASCRIPT_ACTIONS_TO_NODE24: 'true'
ASTRBOT_SOURCE_GIT_REF: ${{ vars.ASTRBOT_SOURCE_GIT_REF || 'master' }}
ASTRBOT_NIGHTLY_SOURCE_GIT_REF: ${{ vars.ASTRBOT_NIGHTLY_SOURCE_GIT_REF || 'master' }}
ASTRBOT_NIGHTLY_SCHEDULE_CRON: ${{ vars.ASTRBOT_NIGHTLY_SCHEDULE_CRON || '7 3 * * *' }}
Expand Down Expand Up @@ -108,7 +109,7 @@ jobs:
setup-python: 'false'

- name: Setup pnpm
uses: pnpm/action-setup@v4.2.0
uses: pnpm/action-setup@v4.4.0
Copy link

@sourcery-ai sourcery-ai bot Mar 19, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚨 suggestion (security): Pin pnpm/action-setup to a full commit SHA for better supply-chain security

Using a mutable tag means this workflow could change behavior without any code change here. To improve supply-chain security, pin this to the exact commit SHA for v4.4.0 (e.g., pnpm/action-setup@<sha>) and optionally add a comment noting it corresponds to v4.4.0.

Suggested implementation:

      - name: Setup pnpm
        # pnpm/action-setup v4.4.0
        uses: pnpm/action-setup@<pnpm-action-setup-v4.4.0-commit-sha>
        with:
          version: 10.28.2

Replace <pnpm-action-setup-v4.4.0-commit-sha> with the actual commit SHA of the v4.4.0 tag from https://github.com/pnpm/action-setup (e.g., run git ls-remote https://github.com/pnpm/action-setup refs/tags/v4.4.0 or check the tag in the GitHub UI and copy the full 40‑char SHA). Keep the comment in sync if you later bump the version.

with:
version: 10.28.2

Expand Down