Skip to content

fix(dashboard): apply labels mapping for list options in config renderer #6844

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Foolllll-J wants to merge 1 commit into
base: master
Choose a base branch
from
+5 −3
Open

fix(dashboard): apply labels mapping for list options in config renderer #6844

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions dashboard/src/components/shared/ConfigItemRenderer.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,19 +86,21 @@
></v-checkbox>
</div>

<v-combobox
<v-select
v-else-if="itemMeta?.type === 'list' && itemMeta?.options"
:model-value="modelValue"
@update:model-value="emitUpdate"
:items="itemMeta.options"
:items="getSelectItems(itemMeta)"
item-title="title"
item-value="value"
:disabled="itemMeta?.readonly"
density="compact"
variant="outlined"
Comment on lines +89 to 98
Copy link
Contributor

@sourcery-ai sourcery-ai bot Mar 23, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

question (bug_risk): Switch from v-combobox to v-select removes ability to enter arbitrary values

This change removes free-form input: v-select only allows choosing from predefined items, while v-combobox also accepted arbitrary text. For type === 'list' configs, this could break cases where users rely on adding values not in options. If free-form entry is still required, consider keeping v-combobox or adding explicit support for custom values; otherwise, please confirm no existing configs depend on non-predefined entries.

class="config-field"
hide-details
chips
multiple
></v-combobox>
></v-select>

<v-select
v-else-if="itemMeta?.options"
Expand Down
Loading