Expose EnsureStableOrdering property in ODataSettings object

[alexmo16]

Changes

• Add possibility of disabling stable ordering.
• Add possibility of disabling default order by clause.

Why

Because in our application we need to disable EnsureStableOrdering in a specific query to improve performance.

[BlaiseD]

AlwaysSortByPrimaryKey is false by default. EnsureStableOrdering is true by default. Both address sorting.

I propose staying with AlwaysSortByPrimaryKey. Use AlwaysSortByPrimaryKey to address the new logic and set it to true for your use case.

Or what am I missing?

[alexmo16]

Thanks for the quick feedback.

FYI, I added EnsureStableOrdering because it is an already existing property of the OData object ODataQuerySettings.

But I'll try your suggestion.

[alexmo16]

@BlaiseD I followed your suggestion and it seems to work and there is less changed code.

The only thing that I'm not sure is that by using AlwaysSortByPrimaryKey we are changing the default behavior.
Currently, when using a $top the SQL query contains an order by even when AlwaysSortByPrimaryKey is set to false, and now I'm changing that.
Maybe it's fine, but I want to double check that with you.

[BlaiseD]

@BlaiseD I followed your suggestion and it seems to work and there is less changed code.

The only thing that I'm not sure is that by using AlwaysSortByPrimaryKey we are changing the default behavior. Currently, when using a $top the SQL query contains an order by even when AlwaysSortByPrimaryKey is set to false, and now I'm changing that. Maybe it's fine, but I want to double check that with you.

Yep - looks like an oversight - and I agree EnsureStableOrdering would have been a better property name for consistency.

[amorelIM]

@BlaiseD Could you please provide an ETA for the next release? This will help me plan accordingly with my team.

[BlaiseD]

7.0.1