Feature: Add ApplyFilterAfterProjection option to control OData filter timing #247
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
BlaiseD
approved these changes
Nov 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #246
Previously, all filters were applied after projection (on the DTO level).
This worked for most cases but caused issues when:
Filters referenced computed or parameterized properties (e.g., values depending on runtime parameters).
AutoMapper’s expression mapping could not propagate runtime parameters into the EF Core query.
As a result, some filters returned empty results even when the projected values were correct.
What’s New
Added ProjectionSettings.ApplyFilterAfterProjection (default: true).
When set to false, filters are mapped and applied before projection (on the entity query).
Updated internal GetQuery logic to choose between pre- and post-projection filtering dynamically.
Added a new test (FilterByDynamicParameterValueBeforeProjectionReturnZeroResults and FilterByDynamicParameterValueAfterProjectionReturnExpectedResults) replicating real-world scenarios with parameterized filters.
Testing
All existing tests pass.
Added new coverage for dynamic parameter filtering behavior.
Verified consistent results across sync/async and different OData configurations.