build: setup ML workspace and VM cluster provisioning via bicep scripts#43
Open
anujsinha3 wants to merge 4 commits intomainfrom
Open
build: setup ML workspace and VM cluster provisioning via bicep scripts#43anujsinha3 wants to merge 4 commits intomainfrom
anujsinha3 wants to merge 4 commits intomainfrom
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #43 +/- ##
=======================================
Coverage 98.63% 98.63%
=======================================
Files 8 8
Lines 292 292
=======================================
Hits 288 288
Misses 4 4 ☔ View full report in Codecov by Sentry. |
carlosgjs
requested changes
Feb 23, 2024
Collaborator
carlosgjs
left a comment
There was a problem hiding this comment.
Looking good! Can you add a README.md that explains how to run this including what tools might be needed?
|
|
||
| @description('The minimum number of nodes to use on the cluster. If not specified, defaults to 0') | ||
| param minNodeCount int = 0 | ||
| @description(' The maximum number of nodes to use on the cluster. If not specified, defaults to 4.') |
Collaborator
There was a problem hiding this comment.
The comment says zero, but the default is 1?
Collaborator
Author
There was a problem hiding this comment.
The cluster does get provisioned with a minimum of 0 nodes. If I remember correctly, the cluster we had also had 0 as its minimum nodes.
Collaborator
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change Description
#21 Configuring bicep script for auto-provision of MLWorkspace and VMCluster
Solution Description
Code Quality
Project-Specific Pull Request Checklists
Bug Fix Checklist
New Feature Checklist
Documentation Change Checklist
Build/CI Change Checklist
Other Change Checklist