94 feat generalized transform norm and distance fct#95
94 feat generalized transform norm and distance fct#95younesStrittmatter wants to merge 2 commits intomainfrom
Conversation
musslick
left a comment
musslick
left a comment
There was a problem hiding this comment.
Looks great! I only have a few minor comments regarding naming and the doc string.
|
|
||
| def norms(arr: np.ndarray) -> np.ndarray: | ||
| """ | ||
| Calculate the norms along the first axis |
There was a problem hiding this comment.
Would be good to explain here in the doc string: The norm of what exactly? E.g., "norm of an nd array). Also, is it norm (singular) or norms (plural)?
| return np.array([np.linalg.norm(np.ravel(row)) for row in arr]) | ||
|
|
||
|
|
||
| def distances(arr_1: np.ndarray, arr_2: np.ndarray) -> np.ndarray: |
There was a problem hiding this comment.
Perhaps consider renaming this function to reflect this is a euclidean distance? E.g., numpy does it the following way:
dst = distance.euclidean(a, b)
| import numpy as np | ||
|
|
||
|
|
||
| def norms(arr: np.ndarray) -> np.ndarray: |
There was a problem hiding this comment.
Perhaps consider renaming this to "norm" for singlular, also to mirror the naming convention in numpy (numpy.linalg.norm)
| return np.array(_lst) | ||
|
|
||
|
|
||
| def to_array_flatten(arr: Union[pd.DataFrame, pd.Series, np.ndarray]) -> np.ndarray: |
There was a problem hiding this comment.
Here, we could either consider having a separate function flatten which can be combined with the to_array function. Alternatively, we could call it to_flat_array?
2 participants
Description
Add generalized transform and metrics for multidementional entries in cells of pd.Dataframes.
Remarks (Optional)
Allthough this makes life a bit harder for collaboraters (they are discouraged to use np metrics directly since theses don't work on nested arrays), I can not think of a better way to do this if we want to keep our package modular and support other formats then single number cell entries