Enable edit forwarding on proxy shape stages.#4481
Merged
seando-adsk merged 4 commits intodevfrom Feb 18, 2026
Merged
Conversation
deboisj
commented
Feb 9, 2026
|
|
||
|
|
||
| find_path(USDEDITFORWARD_INCLUDE_DIR | ||
| find_path(ADSKUSDEDITFORWARD_INCLUDE_DIR |
Collaborator
Author
There was a problem hiding this comment.
As per comment in last PR, aligning with the CC
deboisj
commented
Feb 9, 2026
| set_property(TEST ${target} APPEND PROPERTY LABELS MayaUsd) | ||
| else() | ||
| # If MAYAUSD_FORCE_EF_TEST is set to 1, fail the build when edit forwarding is not found | ||
| if (DEFINED ENV{MAYAUSD_FORCE_EF_TEST} AND "$ENV{MAYAUSD_FORCE_EF_TEST}" STREQUAL "1") |
Collaborator
Author
There was a problem hiding this comment.
Same pattern was what we did for the CC
deboisj
force-pushed
the
deboisj/edit_forward_first_steps
branch
from
019c309 to
fed75b3
Compare
deboisj
commented
Feb 9, 2026
|
|
||
| void MayaUsdEditForwardHost::ExecuteInCmd(std::function<void()> callback, bool immediate) | ||
| { | ||
| if (immediate) { |
Collaborator
Author
There was a problem hiding this comment.
In the future this will need to be wrapped in a undoable command, hence the name. Undo/redo not supported yet
Collaborator
Author
|
I'll need to update the CC before merging this, but code is ready for review. |
pierrebai-adsk
requested changes
Feb 9, 2026
pierrebai-adsk
requested changes
Feb 9, 2026
pierrebai-adsk
previously approved these changes
Feb 9, 2026
seando-adsk
requested changes
Feb 10, 2026
Collaborator
seando-adsk
left a comment
seando-adsk
left a comment
There was a problem hiding this comment.
Overall looks good, just a couple of naming and cmake related changes.
| PRIVATE | ||
| buildInfo.cpp | ||
| debugCodes.cpp | ||
| MayaUsdEditForwardHost.cpp |
Collaborator
There was a problem hiding this comment.
Typically what we do is use the cmake define to conditionally include the entire file. For example see.
| // layers, based on configurable rules authored on the stage's root layer. | ||
| static std::once_flag initHostOnce; | ||
| std::call_once(initHostOnce, []() { | ||
| // The host implements some DCC specific fonctionality for edit forwarding. |
Collaborator
There was a problem hiding this comment.
Minor typo
Suggested change
| // The host implements some DCC specific fonctionality for edit forwarding. | |
| // The host implements some DCC specific functionality for edit forwarding. |
seando-adsk
approved these changes
Feb 10, 2026
pierrebai-adsk
approved these changes
Feb 17, 2026
Collaborator
Author
|
Will close/reopen to try and get the security scan going again. |
deboisj
added
the
ready-for-merge
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.